Last modified: 2014-09-24 15:35:37 UTC
While working with the gwtoolset role in vagrant, i noticed that gwtoolset wasn’t accepting metadata sets whose mediafile URLs contained redirects. this is the same issue that is currently being experienced on commons beta; see bug 70124. In the gwtoolset role, i was able to create a workaround by adding a defined check for CURLOPT_REDIR_PROTOCOLS and setting it to 182, the value i found in my local dev environment. this allowed gwtoolset to follow redirects in URLs and continue processing the metadata set. In irc, bryan davis found this file in the hhvm repo and feels that this is where the issue should actually be addressed: https://github.com/facebook/hhvm/blob/master/hphp/runtime/ext/curl/ext_curl.cpp. until the original file is fixed, i’d like to leave the work around in the gwtoolset role so that the vagrant and commons beta environments will allow gwtoolset to work with metadata sets that include redirect URLs.
Change 158950 had a related patch set uploaded by Dan-nl: GWToolset Role Additions https://gerrit.wikimedia.org/r/158950
upstream issue: https://github.com/facebook/hhvm/issues/3702
Change 159159 had a related patch set uploaded by Dan-nl: Add Curl Constants Test https://gerrit.wikimedia.org/r/159159
Change 159214 had a related patch set uploaded by PleaseStand: CurlHttpRequest: Check library version, not CURLOPT_REDIR_PROTOCOLS https://gerrit.wikimedia.org/r/159214
Change 159214 merged by jenkins-bot: CurlHttpRequest: Check library version, not CURLOPT_REDIR_PROTOCOLS https://gerrit.wikimedia.org/r/159214
Change 158950 merged by jenkins-bot: GWToolset Role Additions https://gerrit.wikimedia.org/r/158950
Change 159257 had a related patch set uploaded by Dan-nl: Remove CURLCURLOPT_REDIR_PROTOCOLS defined test https://gerrit.wikimedia.org/r/159257
Change 159257 merged by jenkins-bot: Remove CURLCURLOPT_REDIR_PROTOCOLS defined test https://gerrit.wikimedia.org/r/159257
Change 159159 merged by jenkins-bot: Add cURL constants test https://gerrit.wikimedia.org/r/159159