Last modified: 2014-09-24 15:35:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72570, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 70570 - HHVM: CURLOPT_REDIR_PROTOCOLS not defined
HHVM: CURLOPT_REDIR_PROTOCOLS not defined
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
GWToolset (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: hhvm, upstream
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-09-08 18:34 UTC by dan
Modified: 2014-09-24 15:35 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description dan 2014-09-08 18:34:20 UTC
While working with the gwtoolset role in vagrant, i noticed that gwtoolset wasn’t accepting metadata sets whose mediafile URLs contained redirects. this is the same issue that is currently being experienced on commons beta; see bug 70124.

In the gwtoolset role, i was able to create a workaround by adding a defined check for CURLOPT_REDIR_PROTOCOLS and setting it to 182, the value i found in my local dev environment. this allowed gwtoolset to follow redirects in URLs and continue processing the metadata set.

In irc, bryan davis found this file in the hhvm repo and feels that this is where the issue should actually be addressed: https://github.com/facebook/hhvm/blob/master/hphp/runtime/ext/curl/ext_curl.cpp.

until the original file is fixed, i’d like to leave the work around in the gwtoolset role so that the vagrant and commons beta environments will allow gwtoolset to work with metadata sets that include redirect URLs.
Comment 1 Gerrit Notification Bot 2014-09-08 18:36:35 UTC
Change 158950 had a related patch set uploaded by Dan-nl:
GWToolset Role Additions

https://gerrit.wikimedia.org/r/158950
Comment 2 dan 2014-09-08 18:53:20 UTC
upstream issue: https://github.com/facebook/hhvm/issues/3702
Comment 3 Gerrit Notification Bot 2014-09-08 19:47:07 UTC
Change 159159 had a related patch set uploaded by Dan-nl:
Add Curl Constants Test

https://gerrit.wikimedia.org/r/159159
Comment 4 Gerrit Notification Bot 2014-09-08 22:44:18 UTC
Change 159214 had a related patch set uploaded by PleaseStand:
CurlHttpRequest: Check library version, not CURLOPT_REDIR_PROTOCOLS

https://gerrit.wikimedia.org/r/159214
Comment 5 Gerrit Notification Bot 2014-09-09 00:08:27 UTC
Change 159214 merged by jenkins-bot:
CurlHttpRequest: Check library version, not CURLOPT_REDIR_PROTOCOLS

https://gerrit.wikimedia.org/r/159214
Comment 6 Gerrit Notification Bot 2014-09-09 02:40:18 UTC
Change 158950 merged by jenkins-bot:
GWToolset Role Additions

https://gerrit.wikimedia.org/r/158950
Comment 7 Gerrit Notification Bot 2014-09-09 05:27:21 UTC
Change 159257 had a related patch set uploaded by Dan-nl:
Remove CURLCURLOPT_REDIR_PROTOCOLS defined test

https://gerrit.wikimedia.org/r/159257
Comment 8 Gerrit Notification Bot 2014-09-09 15:25:40 UTC
Change 159257 merged by jenkins-bot:
Remove CURLCURLOPT_REDIR_PROTOCOLS defined test

https://gerrit.wikimedia.org/r/159257
Comment 9 Gerrit Notification Bot 2014-09-24 15:35:37 UTC
Change 159159 merged by jenkins-bot:
Add cURL constants test

https://gerrit.wikimedia.org/r/159159

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links