Last modified: 2014-09-18 20:15:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72575, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 70575 - VisualEditor: [Regression pre-wmf21] Checking "Border" in media settings dialog is not enabling "Apply changes" button
VisualEditor: [Regression pre-wmf21] Checking "Border" in media settings dial...
Status: VERIFIED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Normal minor
: VE-deploy-2014-09-11
Assigned To: James Forrester
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-09-08 19:56 UTC by Rummana Yasmeen
Modified: 2014-09-18 20:15 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Rummana Yasmeen 2014-09-08 19:56:39 UTC 
Steps to reproduce:

1.Open a page with VE
2.Open Media Settings dialog for a Frameless/Basic type image which does not have "Border" set to it.
3.Now check the "Border" checkbox


Observed Result:
It does not enable the "Apply Changes" button in the media Settings dialog

Environment:Betalabs
Comment 1 Roan Kattouw 2014-09-11 00:06:50 UTC 
This is due to an OOjs bug.

>>> OO.compare( { foo: 3 }, { foo: 4 } )
false

>>> OO.compare( { foo: false }, { foo: true } )
true

Because we have special cases for 'number' and 'string' but not 'boolean'.
Comment 2 Roan Kattouw 2014-09-11 00:27:50 UTC 
Should be fixed by https://gerrit.wikimedia.org/r/#/c/159639/
Comment 3 James Forrester 2014-09-11 00:46:53 UTC 
Released in OOjs 1.1.1, now in MW-core etc.
Comment 4 Rummana Yasmeen 2014-09-12 20:32:06 UTC 
Verified the fix in test2
Comment 5 Rummana Yasmeen 2014-09-18 20:15:44 UTC 
Verified the fix in production
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links