Last modified: 2014-09-19 01:59:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72577, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 70577 - TaskRecommendationImpression isn't fired when flyout is re-opened
TaskRecommendationImpression isn't fired when flyout is re-opened
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
GettingStarted (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Rob Moen
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-09-08 20:22 UTC by Aaron Halfaker
Modified: 2014-09-19 01:59 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Aaron Halfaker 2014-09-08 20:22:42 UTC 
Problem:

The TaskRecommendationImpression event is not sent again when the flyout is hidden and re-opened. 

Steps to reproduce:

0: Got to mediawiki
1: Register an account where user_id mod 4 is 2 or 3
2: Edit a mainspace page
3: Click on "(lightbulb) Recommendations" 
-- TaskRecommendationLightbulbClick & TaskRecommendationImpression is fired
4: Click on body of page outside of flyout
5: Click on "(lightbulb) Recommendations" again
-- TaskRecommendationLightbulbclick is fired, but not TaskRecommendationImpression
Comment 1 Gerrit Notification Bot 2014-09-11 20:27:17 UTC 
Change 159828 had a related patch set uploaded by Robmoen:
Fire TaskRecommendationImpression when flyout is reopened

https://gerrit.wikimedia.org/r/159828
Comment 2 Gerrit Notification Bot 2014-09-19 00:00:03 UTC 
Change 159828 merged by jenkins-bot:
Fire TaskRecommendationImpression when flyout is reopened

https://gerrit.wikimedia.org/r/159828
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links