Last modified: 2014-10-06 12:28:00 UTC
In "Age of unreviewed changesets by affiliation" at http://korma.wmflabs.org/browser/gerrit_review_queue.html, the popup window shows the number of patches counted in the median for each affiliation. However, many of the numbers provided are negative, which doesn't make any sense. I had already reported via email that those numbers looked very low considering the amount of changesets uploaded every month. This was when the numbers were still positive. Seeing negative values suggests that there is indeed something wrong there.
Marking High importance because I would really like to leave the Gerrit Review Queue page absolutely clean.
In fact, this graph should show the media age of their most recent uploads, just like we did with "Age of open changesets" and "Ranking of repositories". Finally, could you change "scr_review_time_pending_ReviewsWaitingForReviewer_days_acc_median" for a human readable string, please?
Ok, the new metric (upload) is generated also for companies, so we can move to this metric and then, fix the number of open issues per company using this new metric. The new metric has already a human label, so the other error will be fixed also. As soon as it is available I will update this ticket.
Quim, problem fixed. Now the pending number per company is right. The problem was that we are showing the new net pending per month, not the total pendings.
Now there are no negative numbers, but they still look low. For August we have: Unknown: 66 Wikimedia Foundation: 55 Independent: 123 Wikimedia Deutschland: 29 TOTAL: 273 However, according to "Volume of open changesets", in August there are 765 waiting for review. 765 - 273 = 492 Where are these 492 changesets missing? By the way, now we have "scr_review_time_pending_upload_ReviewsWaitingForReviewer_days_acc_median", which is still not very readable.
Álvaro, when do you think we will have a solution for this problem? This is the last bug in http://korma.wmflabs.org/browser/gerrit_review_queue.html stopping me from promoting this page widely.
I plan to review all labels and help texts today and next, work on this issue. So expect a solution, or an explanation of the numbers, next two days! Cheers
Quim, the number of reviews now show the correct number. The main problem was that there are new identities not linked to Unknown. With this fixed the numbers are much closer. We have changed the metric for affiliations to "Time from last patchset". Is it ok or you prefer "Time from submission"? With this metric: Unknown: 666 WMF: 36 Independent: 10 WMD: 55 WikiWorks: 0 total: 767. According to the above graph, "Time from last patchset" number of revisions should be 816. For other dates the error is less. A deeper analysis could be done, but I am pretty confident the data is correct.
Progress! It is strange to find so many Unknown. Any developer with a @wikimedia.org email address is a WMF employee. Any developer with a @wikimedia.de address is a WMDE employee. Are we applying these rules?
Quim, reviewed the mapping, now we have: Unknown 479 WMF 206 Individual 124 WMD 8 Wikia 26 total: 843. We need to improve the mapping to have less Unknown people in any case.
Thanks. Hm, after this change, Wikia has a very different line from all the rest. Are we still looking at "waiting for reviewer"? If so, this is worth looking at. Before there was a link to the raw data, but now I can't find it. Could you paste somewhere the gerrit change numbers that are open and owned by Wikia? Also, if you paste a list of the unknown at https://www.mediawiki.org/wiki/Talk:Community_metrics , we will help identifying the affiliation of these contributors.
