Last modified: 2014-11-15 13:10:08 UTC
- clone mediawiki/ruby/api repo[1] - install rubocop gem[2] - run "rubocop --auto-gen-config" - commit .rubocop.yml and .rubocop_todo.yml files to the repo - push the commit to gerrit (with "git review") - create separate commit(s) that solve the problems found by rubocop - feel free to group similar or small problems in one commit - make sure none of the commits is too big, so reviewers do not have a hard time - add me (zfilipin) as a reviewer to every commit that is pushed to gerrit 1: https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/ruby/api 2: https://rubygems.org/gems/rubocop 3: https://github.com/bbatsov/rubocop#automatically-generated-configuration
Change 159630 had a related patch set uploaded by Zfilipin: Add Rubocop files. https://gerrit.wikimedia.org/r/159630
Damien, please assign the bug to yourself so other people know you are working on it. That will prevent somebody else working on it and duplicating the effort. Thanks!
Change 159630 merged by jenkins-bot: Add Rubocop files. https://gerrit.wikimedia.org/r/159630
All patches mentioned in this report were merged or abandoned - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?
I do not think Damien is working on this. Damien, if you are, please assign the bug back to yourself. What is left to do is either resolving offenses from .rubocop_todo.yml[0] or moving them to .rubocop.yml[1], making it explicit that we do not plan to resolve them in the near future. 0: https://github.com/wikimedia/mediawiki-ruby-api/blob/master/.rubocop_todo.yml 1: https://github.com/wikimedia/mediawiki-ruby-api/blob/master/.rubocop.yml
