Last modified: 2014-09-18 20:16:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72611, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 70611 - VisualEditor: ”Use an Existing Reference“ button should be inactive if there are no references to add (the internal list is empty)
VisualEditor: ”Use an Existing Reference“ button should be inactive if there ...
Status: VERIFIED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2014-09-11
Assigned To: Alex Monk
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-09-09 16:06 UTC by Ritu Swain
Modified: 2014-09-18 20:16 UTC (History)
5 users (show)

See Also:
Web browser: Google Chrome
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
screenshot1 (87.46 KB, image/png)
2014-09-09 16:06 UTC, Ritu Swain 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Ritu Swain 2014-09-09 16:06:39 UTC 
Created attachment 16416 [details]
screenshot1

Environment-test2,beta, production.

1> open a page in VE, add a Basic citation.
2>Click to add Basic citation again ,in the modal click on “Use an Existing Reference “.Select the citation that you just added.
3>In the editor pane, delete all the citations.
4> Select  to add Basic citation again. In the modal notice the “Use an Existing Reference “ button is  still active, although there are no citations to add to. Click on it and it opens a blank Reference modal.
See screenshot.
Comment 1 Gerrit Notification Bot 2014-09-09 23:14:22 UTC 
Change 159423 had a related patch set uploaded by Alex Monk:
Properly mark reference search index as empty when setting internal list

https://gerrit.wikimedia.org/r/159423
Comment 2 James Forrester 2014-09-09 23:25:19 UTC 
Nice.
Comment 3 Gerrit Notification Bot 2014-09-09 23:26:49 UTC 
Change 159423 merged by jenkins-bot:
Properly mark reference search index as empty when setting internal list

https://gerrit.wikimedia.org/r/159423
Comment 4 Rummana Yasmeen 2014-09-09 23:56:11 UTC 
The Re-Use option in the Cite menu from the toolbar still remains enabled when there is no reference in the article.
Comment 5 Alex Monk 2014-09-10 00:08:32 UTC 
This bug is about a very specific way to break the existing disabling of a different button. What you propose makes sense but it's not in scope here. I'll take a look into doing it anyway, but I'm going to re-close this bug.
Comment 6 Alex Monk 2014-09-10 00:22:35 UTC 
(Opened bug 70640 for that)
Comment 7 Rummana Yasmeen 2014-09-12 20:32:28 UTC 
Verified the fix in test2
Comment 8 Rummana Yasmeen 2014-09-18 20:16:31 UTC 
Verified the fix in production
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links