Last modified: 2014-09-10 13:54:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72628, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 70628 - wikitech strict warnings on API save
wikitech strict warnings on API save
Status: NEW
Product: Wikimedia Labs
Classification: Unclassified
wikitech-interface (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-09-09 20:44 UTC by jeremyb
Modified: 2014-09-10 13:54 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
morebots-patch-wikitech-strict-warning-2014-09-04.patch (1.29 KB, patch)
2014-09-09 20:44 UTC, jeremyb
Details

Description jeremyb 2014-09-09 20:44:22 UTC
Created attachment 16420 [details]
morebots-patch-wikitech-strict-warning-2014-09-04.patch

+++ This bug was initially created as a clone of Bug #70436 +++

morebots !log to wikitech broke during the upgrade.

API response looks like this:
{"edit":{"result":"Success","pageid":7919,"title":"Server Admin Log","contentmodel":"wikitext","oldrevid":126205,"newrevid":126208,"newtimestamp":"2014-09-09T19:05:40Z"}}<br />
<b>Strict Standards</b>:  Declaration of LuceneResult::getTitleSnippet() should be compatible with that of SearchResult::getTitleSnippet() in <b>/usr/local/apache/common-local/php-1.24wmf15/extensions/MWSearch/MWSearch_body.php</b> on line <b>153</b><br />
 (208.80.154.18)

and so morebots says that's not valid JSON (extra data on the end).

morebots patch attached
Comment 1 Tim Landscheidt 2014-09-09 20:55:27 UTC
(I'm pretty sure this is the same issue, but am not confident.)
Comment 2 Andrew Bogott 2014-09-10 13:54:40 UTC
There is a fix in place now that should resolve those warnings, cherry-picked to the wikitech branch.  Can you please verify if this is correct and, if so, de-hack the bot so it's back to running the standard debian version?  Thx

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links