Last modified: 2014-09-12 15:13:10 UTC
A few users reported seeing this: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7779487 And probably these: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7765031 https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7743485 https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7713913 The code in CreateAccountActivity.handleError basically checks for 'userexists', 'acct_creation_throttle_hit' and 'sorbs_create_account_reason'... If it's none of those, a useless "Could not create account" error is shown.
I agree that that is a suboptimal set of errors to explicitly handle. We could do better. The questions here are primarily product ones, namely: 1) What errors from the API should have their own specific messages and handling? 2) What is the cutoff at which we start surfacing the generic error? 3) What should the text of the specific errors say? Given that I'll likely expend more time in the back-and-forth than if I just look in the codebase myself, I'm going to assume this one is "easy" and take it on as a weekend project.
Change 159669 had a related patch set uploaded by Deskana: Improve the API error handling in the account creation activity. https://gerrit.wikimedia.org/r/159669
Change 159669 merged by jenkins-bot: Improve the API error handling in the account creation activity. https://gerrit.wikimedia.org/r/159669
