Last modified: 2014-09-16 15:34:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72659, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 70659 - DiffViewTest failures on travis!
DiffViewTest failures on travis!
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: High major (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=backend p=0
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-09-10 16:05 UTC by Aude
Modified: 2014-09-16 15:34 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Aude 2014-09-10 16:05:12 UTC
Wikibase tests on travis have been failing on and off (mostly on) for weeks now!

It has something to do with DiffViewTest (and maybe one of the FingerprintView patches, since that's approximately when this issue started).

There were 4 failures:
1) Wikibase\Test\DiffViewTest::testGetHtml with data set "Link is linked" ('@<a\\b[^>]* href="[^"]*\\bNEW"[^>]*>NEW</a>@', NULL, 'NEW', 'وصلات/enwiki')
Diff table content line
Failed asserting that '<tr><td colspan="2">&nbsp;</td><td class="diff-marker">+</td><td class="diff-addedline"><div><ins class="diffchange diffchange-inline">NEW</ins></div></td></tr>' matches PCRE pattern "@<a\b[^>]* href="[^"]*\bNEW"[^>]*>NEW</a>@".
/home/travis/build/wikimedia/phase3/extensions/Wikibase/repo/tests/phpunit/includes/DiffViewTest.php:121
2) Wikibase\Test\DiffViewTest::testGetHtml with data set "Link has direction" ('@<a\\b[^>]* dir="auto"@', NULL, 'NEW', 'وصلات/enwiki')
Diff table content line
Failed asserting that '<tr><td colspan="2">&nbsp;</td><td class="diff-marker">+</td><td class="diff-addedline"><div><ins class="diffchange diffchange-inline">NEW</ins></div></td></tr>' matches PCRE pattern "@<a\b[^>]* dir="auto"@".
/home/travis/build/wikimedia/phase3/extensions/Wikibase/repo/tests/phpunit/includes/DiffViewTest.php:121
3) Wikibase\Test\DiffViewTest::testGetHtml with data set "Link has hreflang" ('@<a\\b[^>]* hreflang="en"@', NULL, 'NEW', 'وصلات/enwiki')
Diff table content line
Failed asserting that '<tr><td colspan="2">&nbsp;</td><td class="diff-marker">+</td><td class="diff-addedline"><div><ins class="diffchange diffchange-inline">NEW</ins></div></td></tr>' matches PCRE pattern "@<a\b[^>]* hreflang="en"@".
/home/travis/build/wikimedia/phase3/extensions/Wikibase/repo/tests/phpunit/includes/DiffViewTest.php:121
4) Wikibase\Test\DiffViewTest::testGetHtml with data set "Badge is linked correctly" ('@<a\\b[^>]* href="/wiki/index\\.php/Item\\:Q123"@', NULL, 'Q123', 'وصلات/enwiki/badges')
Diff table content line
Failed asserting that '<tr><td colspan="2">&nbsp;</td><td class="diff-marker">+</td><td class="diff-addedline"><div><ins class="diffchange diffchange-inline">Q123</ins></div></td></tr>' matches PCRE pattern "@<a\b[^>]* href="/wiki/index\.php/Item\:Q123"@".
Comment 2 Gerrit Notification Bot 2014-09-14 18:01:20 UTC
Change 160289 had a related patch set uploaded by Hoo man:
Call parent::tearDown in FingerprintViewTest

https://gerrit.wikimedia.org/r/160289
Comment 3 Gerrit Notification Bot 2014-09-14 18:24:17 UTC
Change 160289 merged by jenkins-bot:
Call parent::tearDown in FingerprintViewTest

https://gerrit.wikimedia.org/r/160289
Comment 4 Addshore 2014-09-14 19:35:33 UTC
=]
Comment 5 Gerrit Notification Bot 2014-09-16 13:33:04 UTC
Change 160647 had a related patch set uploaded by Aude:
Call parent::tearDown in FingerprintViewTest

https://gerrit.wikimedia.org/r/160647
Comment 6 Gerrit Notification Bot 2014-09-16 15:34:54 UTC
Change 160647 merged by jenkins-bot:
Call parent::tearDown in FingerprintViewTest

https://gerrit.wikimedia.org/r/160647

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links