Last modified: 2014-09-18 19:02:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72731, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 70731 - VisualEditor: The language dialog will not close if you paste in content with an auto direction and no language
VisualEditor: The language dialog will not close if you paste in content with...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2014-09-18
Assigned To: Editing team bugs – take if you're interested!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-09-11 18:45 UTC by WhatamIdoing
Modified: 2014-09-18 19:02 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description WhatamIdoing 2014-09-11 18:45:02 UTC
I haven't tried to reproduce this.  

I copied a page title from Meta and pasted it into VisualEditor on another wiki.  The text was set to =Page title= and highlighted in very pale blue, with a dashed line underneath, so I set it to Paragraph (that worked) and went to the character formatting menu to clear the formatting.  The 'Language' item was highlighted, so I chose that.

The first time, the dialog box that popped up was tiny.  It was barely big enough to display the "done" button, which was overlapping with an odd "$1 AUTO" string in gray text.

The second time, the dialog box looked normal, but 'Remove' didn't actually remove anything.  'Clear formatting' also doesn't remove anything.  

Then the box got stuck open.  It would go away if I highlighted text, but 'Done' didn't close it and clicking outside it didn't close it.

I was able to keep editing and to save the page when I was finished, but it produced <span dir="auto"> tags, which I didn't want.
Comment 1 Roan Kattouw 2014-09-11 19:36:21 UTC
It looks like page titles (at least on meta, possibly elsewhere) are wrapped in <span dir="auto">, which is recognized as a language annotation (because it has a dir attribute) but doesn't work very well once it's considered a language annotation (because it has no lang attribute). I'll poke at this. Earlier, Amir reported a problem with pages containing <span dir="rtl"> tags (also no lang attribute) so maybe this is semi-related.
Comment 2 Gerrit Notification Bot 2014-09-12 21:33:56 UTC
Change 160096 had a related patch set uploaded by Catrope:
(Kind of) fix treatment of strange dir values

https://gerrit.wikimedia.org/r/160096
Comment 3 Gerrit Notification Bot 2014-09-12 21:44:12 UTC
Change 160098 had a related patch set uploaded by Catrope:
Don't return undefined in ve.init.mw.Platform#getLanguageName

https://gerrit.wikimedia.org/r/160098
Comment 4 Gerrit Notification Bot 2014-09-12 21:46:37 UTC
Change 160098 merged by jenkins-bot:
Don't return undefined in ve.init.mw.Platform#getLanguageName

https://gerrit.wikimedia.org/r/160098
Comment 5 Gerrit Notification Bot 2014-09-12 21:48:55 UTC
Change 160096 merged by jenkins-bot:
(Kind of) fix treatment of strange dir values

https://gerrit.wikimedia.org/r/160096

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links