Last modified: 2014-09-29 15:41:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72732, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 70732 - change "inspect diff" to "show diff"
change "inspect diff" to "show diff"
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
RecentActivityFeed (Other open bugs)
master
All All
: Unprioritized minor (vote)
: ---
Assigned To: Nischay Nahata
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-09-11 18:46 UTC by Sage Ross
Modified: 2014-09-29 15:41 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sage Ross 2014-09-11 18:46:34 UTC
If an inline diff has not been loaded yet, the link to load it says "inspect diff". If a user inspects this diff and then clicks "hide diff", the text will then say "show diff" instead. This makes sense in terms of what the script is doing, since it only needs to load the data the first time. But from a user's perspective there is no difference; in both cases, you simply click the link to see the diff.

The text should simply read "show diff", whether or not the diff has already been loaded and hidden.
Comment 1 Gerrit Notification Bot 2014-09-25 20:07:55 UTC
Change 162964 had a related patch set uploaded by Nischayn22:
Bug 70732  change inspect diff to show diff

https://gerrit.wikimedia.org/r/162964
Comment 2 Nischay Nahata 2014-09-25 20:09:08 UTC
Feel free to review and merge this Sage.
Comment 3 Gerrit Notification Bot 2014-09-29 15:41:11 UTC
Change 162964 merged by Nischayn22:
Bug 70732  change inspect diff to show diff

https://gerrit.wikimedia.org/r/162964

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links