Last modified: 2014-10-21 17:40:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72748, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 70748 - "Remove from course" button no longer works


Summary:	"Remove from course" button no longer works

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	EducationProgram (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	High major (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:	code-update-regression

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-09-12 00:00 UTC by Sage Ross
Modified:	2014-10-21 17:40 UTC (History)
CC List:	7 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Sage Ross 2014-09-12 00:00:25 UTC

Users with advanced rights have an option to remove users as students from a course page: the "remove from course" link in the students table brings a confirmation dialog, and normally when you click "Remove student" to confirm it, the user is removed from the course.

As noticed today, this no longer works. After clicking "Remove student", the user remains listed as a student.

Comment 1 Sage Ross 2014-09-12 00:41:21 UTC

The similar "remove as reviewer" link, which uses the same type of popup confirmation dialog, still works. (Thus, maybe it's not a javascript problem?)

Also, the enrolled user can still remove themselves using the Disenroll button from the top right tabs overflow pulldown ("More").

Comment 2 Andrew Green 2014-09-15 20:48:34 UTC

I was able to reproduce this locally with core and the EducationProgram extension at version MediaWiki 	1.24wmf21.

Comment 3 Andrew Green 2014-09-16 19:20:45 UTC

The problem comes from recent changes in ApiBase:

https://gerrit.wikimedia.org/r/#/c/153110/

Still running into a few obstacle in getting it to work. I'll post more if I'm not successful soon...

Comment 4 Gerrit Notification Bot 2014-09-17 02:01:09 UTC

Change 160901 had a related patch set uploaded by AndyRussG:
Fix RemoveStudentAction after API token overhaul

https://gerrit.wikimedia.org/r/160901

Comment 5 Gerrit Notification Bot 2014-09-18 14:53:58 UTC

Change 160901 merged by jenkins-bot:
Fix RemoveStudentAction after API token overhaul

https://gerrit.wikimedia.org/r/160901

Comment 6 vojtech.dostal@wikimedia.cz 2014-09-23 16:07:23 UTC

Hi, the same problem occurs on Czech Wikipedia. Can you estimate when this gets solved?

Comment 7 Sage Ross 2014-09-23 16:30:25 UTC

@vojtech: The fix got merged last week before the new deployment branch, which means it should go live this Thursday.

Comment 8 vojtech.dostal@wikimedia.cz 2014-09-23 16:31:37 UTC

@sage Thank you for information, that's brilliant:)

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links