Last modified: 2014-11-20 18:49:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72767, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 70767 - Do not load full entities when invoking LinkBegin hook
Do not load full entities when invoking LinkBegin hook
Status: ASSIGNED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=backend p=8 s=2014-11-11
:
Depends on: 68026 71169
Blocks: 71519
  Show dependency treegraph
 
Reported: 2014-09-12 11:40 UTC by Aude
Modified: 2014-11-20 18:49 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Aude 2014-09-12 11:40:01 UTC
We load full entities for the onLinkBegin hook handler in Wikibase Repo in order to get a label.

e.g. for each item or property on Special:Allpages, we load the entity to get the label.

a term lookup, with caching and all, should be used instead.

LinkBegin is also used in places like Special:Watchlist (i think), so if someone has a gigantic watchlist, it probably will timeout.
Comment 1 Aude 2014-11-20 18:48:38 UTC
part of the solution to this is to avoid using Linker whenever possible.

We are currently using Linker to format property id links in ClaimsView and SnakHtmlGenerator.  Instead we should use an EntityIdHtmlLinkFormatter that makes use of an EntityInfoTermLookup / LabelLookup for this.
Comment 2 Aude 2014-11-20 18:49:01 UTC
by not using Linker, we don't encounter this hook.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links