Last modified: 2014-10-15 09:40:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72834, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 70834 - Crash caused by pressing Retry button on connection issue error
Crash caused by pressing Retry button on connection issue error
Status: REOPENED
Product: Wikipedia App
Classification: Unclassified
Android App (Other open bugs)
Beta
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-09-15 00:50 UTC by Alex Monk
Modified: 2014-10-15 09:40 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Alex Monk 2014-09-15 00:50:49 UTC
I managed to get the app to crash by trying to load the app without a connection, turning it on and then spamming the Retry button.

I haven't been able to reproduce it since, but when I do it now, I get the last updated & licensing footer at the top of the page.

Copy from my ticket at https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7805837 here:

ANDROID_VERSION=4.3
APP_VERSION_NAME=2.0-beta-2014-09-09
BRAND=OPPO
PHONE_MODEL=X9006
CUSTOM_DATA=
STACK_TRACE=java.lang.IndexOutOfBoundsException: Invalid index 2, size is 1
at java.util.ArrayList.throwIndexOutOfBoundsException(ArrayList.java:255)
at java.util.ArrayList.get(ArrayList.java:308)
at org.wikipedia.beta.page.PageViewFragment$1.run(PageViewFragment.java:277)
at android.os.Handler.handleCallback(Handler.java:730)
at android.os.Handler.dispatchMessage(Handler.java:92)
at android.os.Looper.loop(Looper.java:137)
at android.app.ActivityThread.main(ActivityThread.java:5166)
at java.lang.reflect.Method.invokeNative(Native Method)
at java.lang.reflect.Method.invoke(Method.java:525)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:745)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:561)
at dalvik.system.NativeStart.main(Native Method)
Comment 1 Bernd Sitzmann 2014-09-16 03:19:41 UTC
I was able to repro this pretty much every time. I believe this is the same as Alex was able to.
Airplane mode on -> follow link to another page -> Airplane mode off -> hit the retry button like a madman, esp. before the connection comes back -> boom
Comment 2 Gerrit Notification Bot 2014-09-16 03:20:27 UTC
Change 160604 had a related patch set uploaded by BearND:
Slow down retry button

https://gerrit.wikimedia.org/r/160604
Comment 3 Gerrit Notification Bot 2014-09-16 14:01:43 UTC
Change 160604 merged by Dbrant:
Slow down retry button

https://gerrit.wikimedia.org/r/160604
Comment 4 Alex Monk 2014-09-16 15:45:21 UTC
Assuming this is fixed.
Comment 5 Alex Monk 2014-09-24 12:22:42 UTC
But is it really? https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7792494 reports what appears to be the same stack trace again...
Comment 6 Dan Garry 2014-09-24 18:24:37 UTC
(In reply to Alex Monk from comment #5)
> But is it really?
> https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;
> TicketID=7792494 reports what appears to be the same stack trace again...

And he's running a beta that's dated after the fix was merged. Reopening accordingly.
Comment 8 Gerrit Notification Bot 2014-10-07 17:06:57 UTC
Change 165244 had a related patch set uploaded by Dbrant:
Guard against index-out-of-bounds when loading sections.

https://gerrit.wikimedia.org/r/165244
Comment 9 Gerrit Notification Bot 2014-10-07 21:29:03 UTC
Change 165244 merged by jenkins-bot:
Guard against index-out-of-bounds when loading sections.

https://gerrit.wikimedia.org/r/165244

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links