Last modified: 2014-10-24 15:00:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72862, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 70862 - monitor unsigned salt keys
monitor unsigned salt keys
Status: NEW
Product: Wikimedia Labs
Classification: Unclassified
deployment-prep (beta) (Other open bugs)
unspecified
All All
: Low enhancement
: ---
Assigned To: Nobody - You can work on this!
: easy
Depends on:
Blocks: 51497
  Show dependency treegraph
 
Reported: 2014-09-15 20:09 UTC by Antoine "hashar" Musso (WMF)
Modified: 2014-10-24 15:00 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Antoine "hashar" Musso (WMF) 2014-09-15 20:09:13 UTC
Whenever an instance is added to the beta cluster and switched to the local salt master, we might forget to sign the key on the salt master.  We should get a monitoring for any unsigned or rejected keys:

Example:

root@deployment-salt:~# salt-key --list rejected
Rejected Keys:
root@deployment-salt:~# salt-key --list unsigned
Unaccepted Keys:
i-000004f8.eqiad.wmflabs
i-000005ba.eqiad.wmflabs
root@deployment-salt:~#
Comment 1 Antoine "hashar" Musso (WMF) 2014-09-16 07:41:57 UTC
Yuvi, I am not sure how familiar you are with diamond. Would it make sense to write a basic collector that list the rejected/unsigned keys on the salt master, send that to graphite and alert on them?
Comment 2 Yuvi Panda 2014-09-16 10:13:20 UTC
Indeed, that seems ok to do. *Ideally* we would just do this in icinga instead of with diamond, but considering icinga status on labs I'd say go ahead with doing it in diamond. We already have written some custom collectors for us (see minimalpuppetagent.py), and it should be fairly trivial to copy that and use it here.

Do you want to give it a shot? I can help with the diamond bits :)
Comment 3 Antoine "hashar" Musso (WMF) 2014-09-16 10:16:20 UTC
I already have too many things to complete which are long overdue. So I am unlikely to look at writing a diamond collector anytime soon.  If you have some spare bandwidth, please step in :-D
Comment 4 Yuvi Panda 2014-09-16 10:17:20 UTC
Alright, I'll put it on my 'spare bandwidth TODO' list :)

In the meantime, if anyone else wants to step in, please do! I'll be happy to help.
Comment 5 Ariel T. Glenn 2014-10-24 15:00:10 UTC
no autoacceptance in the works?  That would take care of the problem.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links