Last modified: 2014-09-17 17:56:07 UTC
Running PHPUnit tests against PagedTiffHandler for https://gerrit.wikimedia.org/r/#/c/86413 results in different warnings locally to on Jenkins: root@ubuntu64-web-esxi:/var/www/wiki/mediawiki/core/tests/phpunit# php phpunit.php --with-phpunitdir /var/www/wiki/mediawiki ../../extensionsgit/PagedTiffHandler/tests/PagedTiffHandlerTest.php Will attempt loading PHPUnit from `/var/www/wiki/mediawiki` #!/usr/bin/env php PHPUnit 4.2.5 by Sebastian Bergmann. Configuration read from /var/www/wiki/mediawiki/core/tests/phpunit/suite.xml ......E.......E. Time: 5.6 seconds, Memory: 26.00Mb There were 2 errors: 1) PagedTiffHandlerTest::testDoTransform Array to string conversion /var/www/wiki/mediawiki/core/includes/media/TransformationalImageHandler.php:167 /var/www/wiki/mediawiki/extensions/PagedTiffHandler/tests/PagedTiffHandlerTest.php:157 /var/www/wiki/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:141 2) PagedTiffHandlerTest::testTransformNotTooBig Array to string conversion /var/www/wiki/mediawiki/core/includes/media/TransformationalImageHandler.php:167 /var/www/wiki/mediawiki/extensions/PagedTiffHandler/tests/PagedTiffHandlerTest.php:278 /var/www/wiki/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:141 FAILURES! Tests: 16, Assertions: 63, Errors: 2. root@ubuntu64-web-esxi:/var/www/wiki/mediawiki/core/tests/phpunit# 167 is: wfDebug( __METHOD__ . ": creating {$scalerParams['physicalDimensions']} " . "thumbnail at $dstPath using scaler $scaler\n" ); $scaler can seemingly be: @return string|Callable One of client, im, custom, gd, imext, or a Callable array
var_dump-ing $scaler gives: array(2) { [0]=> object(PagedTiffHandler)#620 (0) { } [1]=> string(11) "transformIM" }
Not seemingly caused by https://gerrit.wikimedia.org/r/#/c/147718/ - the code is just moved... So presumably it's actually the extension at fault (issue isn't there with master of PagedTiffHandler, just with 86413 in it)
(In reply to Sam Reed (reedy) from comment #2) > So presumably it's actually the extension at fault -> moving to its component
Change 160978 had a related patch set uploaded by Reedy: Array to string conversion in TransformationalImageHandler.php:167 https://gerrit.wikimedia.org/r/160978
Change 160978 merged by jenkins-bot: Array to string conversion in TransformationalImageHandler.php:167 https://gerrit.wikimedia.org/r/160978
successfully merged
