Last modified: 2014-09-17 18:58:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72944, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 70944 - Saved Pages fail to load
Saved Pages fail to load
Status: RESOLVED FIXED
Product: Wikipedia App
Classification: Unclassified
Android App (Other open bugs)
Beta
All All
: Unprioritized major
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-09-17 16:32 UTC by Bernd Sitzmann
Modified: 2014-09-17 18:58 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Bernd Sitzmann 2014-09-17 16:32:07 UTC 
From
https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7801873

Sometimes saved pages cannot be loaded when offline. A toast with "Refreshing saved page" appears, followed by Network error and the Retry button.
This started with 2.0-beta-2014-09-09.

Analysis:
In the debugger I see a FileNotFoundException when trying to load some pages.
Looks like the identifier for the saved page is unstable because PageTitle.toJSON() sometimes includes the thumbUrl and other times it doesn't. This makes is useless for an ID. 
PageTitle used to be immutable but was made mutable on 9/9/2014.

We should:
* add another method to be used for IDs
* make it immutable again
Comment 1 Gerrit Notification Bot 2014-09-17 17:53:44 UTC 
Change 160994 had a related patch set uploaded by BearND:
Fix loading saved pages while offline

https://gerrit.wikimedia.org/r/160994
Comment 2 Gerrit Notification Bot 2014-09-17 18:25:18 UTC 
Change 160994 merged by Dbrant:
Fix loading saved pages while offline

https://gerrit.wikimedia.org/r/160994
Comment 3 Alex Monk 2014-09-17 18:58:49 UTC 
Assuming this is fixed now.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links