Last modified: 2014-10-23 21:54:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72957, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 70957 - VisualEditor: Highlight missing parameters in template dialog when complaining about them


Summary:	VisualEditor: Highlight missing parameters in template dialog when complainin...

Status:	VERIFIED FIXED

Product:	VisualEditor
Classification:	Unclassified
Component:	Editing Tools (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal enhancement
Target Milestone:	VE-deploy-2014-10-16
Assigned To:	Alex Monk

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-09-17 20:10 UTC by Roan Kattouw
Modified:	2014-10-23 21:54 UTC (History)
CC List:	4 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Roan Kattouw 2014-09-17 20:10:41 UTC

TODO someone needs to figure out what the visual treatment should look like

The inputs in question already match :required:empty , so we can probably do most of this with CSS.

Comment 1 James Forrester 2014-09-17 20:18:04 UTC

Possible options:

* Put a red(?) ring/border around the field
* Put a red(?) ring/border around the field's label
* Make the field's indicator red(?)
* Make the field's background red(?)

This class we'd toggle on/off should probably be in OOUI.

Comment 2 Gerrit Notification Bot 2014-09-19 19:44:36 UTC

Change 161516 had a related patch set uploaded by Alex Monk:
Make InputWidget mixin FlaggedElement

https://gerrit.wikimedia.org/r/161516

Comment 3 Gerrit Notification Bot 2014-09-19 22:14:53 UTC

Change 161613 had a related patch set uploaded by Alex Monk:
Style required but currently-invalid parameters on the template dialog

https://gerrit.wikimedia.org/r/161613

Comment 4 Gerrit Notification Bot 2014-09-23 20:17:30 UTC

Change 161516 merged by jenkins-bot:
TextInputWidget: Determine validity on blur and change.

https://gerrit.wikimedia.org/r/161516

Comment 5 Gerrit Notification Bot 2014-09-23 23:50:31 UTC

Change 162511 had a related patch set uploaded by Alex Monk:
TextInputWidget: Determine validity in onEdit rather than in setValue

https://gerrit.wikimedia.org/r/162511

Comment 6 Gerrit Notification Bot 2014-09-29 22:48:08 UTC

Change 162511 merged by jenkins-bot:
TextInputWidget: Add setValidation function to change pattern used to validate text

https://gerrit.wikimedia.org/r/162511

Comment 7 Gerrit Notification Bot 2014-10-14 18:43:07 UTC

Change 161613 merged by jenkins-bot:
Style required but currently-invalid parameters on the template dialog

https://gerrit.wikimedia.org/r/161613

Comment 8 Rummana Yasmeen 2014-10-23 21:54:14 UTC

Verified the fix in production

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links