Last modified: 2014-10-07 07:35:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72969, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 70969 - ResourceWarning unclosed files py3


Summary:	ResourceWarning unclosed files py3

Status:	RESOLVED FIXED

Product:	Pywikibot
Classification:	Unclassified
Component:	tests (Other open bugs)
Version:	core-(2.0)
Hardware:	All All

Importance:	Unprioritized normal
Target Milestone:	---
Assigned To:	Pywikipedia bugs

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	pwbpy3
	Show dependency tree / graph

Reported:	2014-09-17 22:26 UTC by John Mark Vandenberg
Modified:	2014-10-07 07:35 UTC (History)
CC List:	0 users

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description John Mark Vandenberg 2014-09-17 22:26:21 UTC

test_XmlDumpAllRevs (tests.xmlreader_tests.XmlReaderTestCase) ... c:\pywiki\core\tests\xmlreader_tests.py:25: ResourceWarning: unclosed file <_io.TextIOWrapper name='c:\\pywiki\\core\\tests\\data\\article-pear.xml' mode='r' encoding='cp
1252'>
  pages = [r for r in
ok
test_XmlDumpFirstRev (tests.xmlreader_tests.XmlReaderTestCase) ... c:\pywiki\core\tests\xmlreader_tests.py:38: ResourceWarning: unclosed file <_io.TextIOWrapper name='c:\\pywiki\\core\\tests\\data\\article-pear.xml' mode='r' encoding='c
p1252'>
  pages = [r for r in
ok
test_XmlDumpRedirect (tests.xmlreader_tests.XmlReaderTestCase) ... ERROR
c:\Python34\lib\unittest\case.py:605: ResourceWarning: unclosed file <_io.TextIOWrapper name='c:\\pywiki\\core\\tests\\data\\article-pyrus.xml' mode='r' encod
ing='cp1252'>
  outcome.errors.clear()

Comment 1 John Mark Vandenberg 2014-09-17 23:18:19 UTC

Another unclosed file in

test_user_agent (tests.dry_site_tests.TestDrySite) ... c:\Python34\lib\subprocess.py:754: ResourceWarning: unclosed file <_io.BufferedReader name=3>
  _cleanup()
ok

c:\Python34\lib\unittest\suite.py:110: ResourceWarning: unclosed file <_io.TextIOWrapper name='c:\\pywiki\\core\\tests\\data\\csv_ingestion.csv' mode='r' encoding='cp1252'>
  for index, test in enumerate(self):
test_getDescription (tests.data_ingestion_tests.TestCSVReader) ... ok
test_getTitle (tests.data_ingestion_tests.TestCSVReader) ... ok
c:\Python34\lib\unittest\suite.py:87: ResourceWarning: unclosed file <_io.TextIOWrapper name='c:\\pywiki\\core\\tests\\data\\csv_ingestion.csv' mode='r' encoding='cp1252'>
  return self.run(*args, **kwds)

Comment 2 Gerrit Notification Bot 2014-09-18 08:26:37 UTC

Change 161195 had a related patch set uploaded by XZise:
[FIX] Close opened files

https://gerrit.wikimedia.org/r/161195

Comment 3 Gerrit Notification Bot 2014-09-18 12:41:43 UTC

Change 161195 merged by jenkins-bot:
[FIX] Close opened files and open XMLs in binary mode

https://gerrit.wikimedia.org/r/161195

Comment 4 Gerrit Notification Bot 2014-09-18 12:46:23 UTC

Change 161227 had a related patch set uploaded by XZise:
[FIX] Close csv file and subprocess stdout streams

https://gerrit.wikimedia.org/r/161227

Comment 5 Gerrit Notification Bot 2014-09-19 20:59:40 UTC

Change 161227 merged by jenkins-bot:
[FIX] Close subprocess stdout streams

https://gerrit.wikimedia.org/r/161227

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links