Last modified: 2014-11-18 23:39:26 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72979, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 70979 - EventLogging cannot find schemas on MW-Vagrant
EventLogging cannot find schemas on MW-Vagrant
Status: RESOLVED FIXED
Product: MediaWiki-Vagrant
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Tisza Gergő
:
: 70183 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-09-18 00:13 UTC by Tisza Gergő
Modified: 2014-11-18 23:39 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Tisza Gergő 2014-09-18 00:13:56 UTC
To reproduce, enable navigationtiming role (or anything else with logging) and load a page. On the browser console you will see

    Validation error against schema NavigationTiming: Unknown schema: NavigationTiming

This started some time summer IIRC. EventLogging never actually *worked* on Vagrant (it didn't log anything) but that wasn't particularly problematic as the client-side behavior was realistic. With this recent change, though, it's not possible to see whether EventLogging is configured correctly in the code that's being tested on the vagrant box.
Comment 1 Tisza Gergő 2014-09-18 12:03:33 UTC
The object mw.eventLog.schema.NavigationTiming exists, has a revision number, but no properties.
Comment 2 Tisza Gergő 2014-09-18 12:10:14 UTC
ResourceLoader loads the schema.NavigationTiming module which contains

  mediaWiki.eventLog.declareSchema("NavigationTiming",{"schema":{},"revision":8365252});mw.loader.state({"schema.NavigationTiming":"ready"});

so the problem is on the server side.
Comment 3 Tisza Gergő 2014-09-18 12:24:38 UTC
This is caused by gerrit change Ife2f0933fd1ae17d1f527ba0d85957d9589f68b9 which set out to fully isolate browser tests by getting rid of the meta.wikimedia.org dependency.

I would argue that was the wrong choice. Given that schema pages on meta are cheap to experiment with, I think the typical development workflow is to create the schema on meta first, and develop/test against that. The tests using it as an external dependency is fine; as a matter of fact, a test becomes less valuable if it does not warn me that my code is broken because it does not match the schema config at meta.

Using local schemas might be a valuable option in special cases, but for the huge majority of developers who don't want to get into the internals of EventLogging just to understand why their code does not seem to work correctly, and don't want to maintain schemas in duplicate, the default setting should be meta.

(Also, the current setting is either broken or relies on a local setup which has not been fully vagrantized. $wgEventLoggingSchemaApiUri is set to http://localhost/w/api.php instead of http://localhost:8080/w/api.php, and even the latter setting would not work without further configuration such as a correct setting for $wgEventLoggingDBname.)
Comment 4 Gerrit Notification Bot 2014-09-18 12:26:23 UTC
Change 161223 had a related patch set uploaded by Gergő Tisza:
Revert "EventLogging role: set a local $wgEventLoggingSchemaApiUri"

https://gerrit.wikimedia.org/r/161223
Comment 5 Gerrit Notification Bot 2014-10-10 23:21:47 UTC
Change 161223 merged by jenkins-bot:
Revert "EventLogging role: set a local $wgEventLoggingSchemaApiUri"

https://gerrit.wikimedia.org/r/161223
Comment 6 Andre Klapper 2014-11-12 15:03:48 UTC
All patches mentioned in this report were merged or abandoned - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?
Comment 7 Tisza Gergő 2014-11-18 23:39:26 UTC
*** Bug 70183 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links