Last modified: 2014-11-12 18:30:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72982, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 70982 - Flow: {{Foo}} in topic title is treated as a template in topic placeholder
Flow: {{Foo}} in topic title is treated as a template in topic placeholder
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-09-18 01:46 UTC by spage
Modified: 2014-11-12 18:30 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2014-09-18 01:46:41 UTC
Create a topic with "Title has {{foo}} in it" as the title.
In the same session, the placeholder text for a top-level topic reply becomes
  Reply to "Title has  in it"

Now reload the board, or follow the Permalink to the topic.  The placeholder for a top-level topic reply becomes
  Reply to "Title has [[:Template:Foo]] in it"

It seems the progressive enhancement on the client is evaluating {{Foo}} as a handlebars template, while the server is evaluating it as wikitext.  Both are incorrect, titles are plain text and should appear that way in the placeholder.

When you view the topic permalink, its HTML page <title> seems to have correct escaping of the topic title.

To reproduce both bugs, view http://en.wikipedia.beta.wmflabs.org/wiki/Talk:Flow  so you see "This topic has ..." and "Another topic with..." posts, and then click to change the sort order.

Erik has a patch, Gerrit change #161101
Comment 1 Gerrit Notification Bot 2014-09-18 03:32:38 UTC
Change 161158 had a related patch set uploaded by EBernhardson:
Don't run progressiveEnhancements through handlebars.js

https://gerrit.wikimedia.org/r/161158
Comment 2 Gerrit Notification Bot 2014-09-23 03:18:37 UTC
Change 161158 merged by jenkins-bot:
Don't run progressiveEnhancements through handlebars.js

https://gerrit.wikimedia.org/r/161158
Comment 3 Gerrit Notification Bot 2014-09-23 18:29:57 UTC
Change 162311 had a related patch set uploaded by EBernhardson:
Don't run progressiveEnhancements through handlebars.js

https://gerrit.wikimedia.org/r/162311
Comment 4 Gerrit Notification Bot 2014-09-23 18:36:02 UTC
Change 162311 merged by jenkins-bot:
Don't run progressiveEnhancements through handlebars.js

https://gerrit.wikimedia.org/r/162311
Comment 5 Andre Klapper 2014-11-12 15:12:23 UTC
All patches mentioned in this report were merged or abandoned - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links