Last modified: 2014-09-25 11:49:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72997, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 70997 - Refactor EntitySearchTextGenerator and ItemSearchTextGenerator
Refactor EntitySearchTextGenerator and ItemSearchTextGenerator
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=backend p=0
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-09-18 13:15 UTC by Daniel Kinzler
Modified: 2014-09-25 11:49 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Daniel Kinzler 2014-09-18 13:15:39 UTC 
ItemSearchTextGenerator and EntitySearchTextGenerator are currently incompatible. This leads to ItemContent::getTextForSearchIndex() re-implementing the logic in EntityContent::getTextForSearchIndex(). This code dublication has big potential for confusion.

Instead, ItemSearchTextGenerator and EntitySearchTextGenerator should share an interface, which a generic implementation of getTextForSearchIndex could use.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links