Last modified: 2014-10-13 18:09:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73002, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 71002 - mediawiki.action.view.redirect.js: Not idempotent when used on double redirect (refreshing the page redirects the user elsewhere)
mediawiki.action.view.redirect.js: Not idempotent when used on double redirec...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.24rc
All All
: Normal minor (vote)
: 1.24.0 release
Assigned To: Bartosz Dziewoński
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-09-18 15:09 UTC by Bartosz Dziewoński
Modified: 2014-10-13 18:09 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bartosz Dziewoński 2014-09-18 15:09:43 UTC
mediawiki.action.view.redirect.js is not idempotent when used on double redirect, on a wiki where $wgMaxRedirects is 1 (the default). Refreshing the redirect page redirects the user further in the chain.

To reproduce, create redirect chain A → B → C, then visit A. Observe that you're seeing B. Refresh the page, you're seeing C now.

We probably need to add ?redirect=no to the URL in some cases.
Comment 1 Bartosz Dziewoński 2014-09-28 15:08:37 UTC
This is apparently noticeable/problematic enough that people notice it and complain on VPT, so I guess I'm going to fix it myself…
Comment 2 Gerrit Notification Bot 2014-09-28 15:28:26 UTC
Change 163465 had a related patch set uploaded by Bartosz Dziewoński:
Article: Handle double redirects in data for mediawiki.action.view.redirect

https://gerrit.wikimedia.org/r/163465
Comment 3 Gerrit Notification Bot 2014-09-29 17:41:59 UTC
Change 163465 merged by jenkins-bot:
Article: Handle double redirects in data for mediawiki.action.view.redirect

https://gerrit.wikimedia.org/r/163465
Comment 4 Gerrit Notification Bot 2014-10-13 18:02:51 UTC
Change 166446 had a related patch set uploaded by Bartosz Dziewoński:
Article: Handle double redirects in data for mediawiki.action.view.redirect

https://gerrit.wikimedia.org/r/166446
Comment 5 Gerrit Notification Bot 2014-10-13 18:09:46 UTC
Change 166446 merged by jenkins-bot:
Article: Handle double redirects in data for mediawiki.action.view.redirect

https://gerrit.wikimedia.org/r/166446

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links