Last modified: 2014-10-22 10:17:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73029, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 71029 - Zuul: reporting of successful test runs blocked on unrelated, incomplete test runs
Zuul: reporting of successful test runs blocked on unrelated, incomplete test...
Status: RESOLVED WORKSFORME
Product: Wikimedia
Classification: Unclassified
Continuous integration (Other open bugs)
wmf-deployment
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-09-18 23:38 UTC by Ori Livneh
Modified: 2014-10-22 10:17 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot of https://integration.wikimedia.org/zuul/ (162.55 KB, image/png)
2014-09-18 23:38 UTC, Ori Livneh
Details

Description Ori Livneh 2014-09-18 23:38:36 UTC
Created attachment 16518 [details]
Screenshot of https://integration.wikimedia.org/zuul/

It seems that the reporting of successful test runs is blocked while there exist test runs that were initiated earlier, regardless of whether or not the runs are related in any way. See screenshot.
Comment 1 Antoine "hashar" Musso (WMF) 2014-09-19 08:06:02 UTC
I have enabled that behavior yesterday and it is totally unexpected although undocumented/unannounced.  The screenshot shows three changes that have been +2ed and thus are entered by Zuul in a queue of patches to merge. They are:

1) https://gerrit.wikimedia.org/r/#/c/154868/ mediawiki/core [master]  
2) https://gerrit.wikimedia.org/r/#/c/160813/ mediawiki/extensions/Thanks [master]
3) https://gerrit.wikimedia.org/r/#/c/161380/ mediawiki/extensions/WikimediaEvents [wmf/1.24wmf21]

Since extensions relies on mediawiki/core, if a change for it is about to land, we need to make sure that changes +2ed after will work with that change to mediawiki/core. It hasn't been merged yet but will certainly be if tests pass and can potentially break follow up changes.

When change 2 to Thanks enters the Zuul queue, Zuul craft a git reference pointing to the commit of mediawiki/core made by change 1.   When preparing the git repositories for Thanks, Zuul will instruct to fetch Change 1 of mediawiki/core instead of the master branch.  Thus Change 2 is tested with mediawiki/core @ Change 1.

The same goes for change 3, although in this case it is in a different branch (wmf).  But Zuul is not smart enough to understand that they are unrelated and still enqueue it behind.   The WikimediaEvents could well trigger a test depending on mediawiki/core @ master, thus it would need to be tested with mediawiki/core + Change 1.


I have documented the feature in Zuul: http://ci.openstack.org/zuul/gating.html#cross-projects-dependencies   I have yet to figure out a place / way to document it for our developers.  And I should definitely announce it.

That being said, I am quite happy you noticed the altered behavior :-]
Comment 2 Antoine "hashar" Musso (WMF) 2014-09-22 08:05:31 UTC
Working as expected albeit barely documented / highlighted.
Comment 3 Antoine "hashar" Musso (WMF) 2014-10-22 10:17:46 UTC
See also https://phabricator.wikimedia.org/T795

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links