Last modified: 2014-09-19 05:08:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73030, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 71030 - Packed gallery with 2 arguments outputs invalid HTML


Summary:	Packed gallery with 2 arguments outputs invalid HTML

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	Parser (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Duplicates:	68228 (view as bug list)
Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-09-19 00:35 UTC by Jon
Modified:	2014-09-19 05:08 UTC (History)
CC List:	2 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Jon 2014-09-19 00:35:17 UTC

Copy the following into your wiki page:
<gallery mode="packed-overlay">
File:Image.png|link=Foo|Air Assault
</gallery>

You'll notice this generates the markup:
<ul class="gallery mw-gallery-packed-overlay">
		<li class="gallerybox" style="width: 122px">
      <div style="width: 122px">
  			<div class="thumb" style="width: 120px;">
          <div style="margin:0px auto;">
            <a href="/wiki/Foo">
              <img alt=""
                src="http://upload.wikimedia.org/wikipedia/commons/thumb/3/34/Image.png/180px-Image.png"
                width="120" height="120" data-file-width="500" data-file-height="500" />
            </a>
          </div>
        </div>
  			<div class="gallerytextwrapper" style="width: 100px">
          <div class="gallerytext">
            <p>Air Assault</p>
          </div>
        </div>
    </li>
</ul>

which has an unclosed DIV tag (the div <div style="width: 122px">)

this can cause problems with the Minerva skin, e.g. break rendering of footer (see bug 68228 for details)

Comment 1 Jon 2014-09-19 00:35:58 UTC

*** Bug 68228 has been marked as a duplicate of this bug. ***

Comment 2 Bawolff (Brian Wolff) 2014-09-19 03:26:55 UTC

Well that's embarrassing...

Comment 3 Gerrit Notification Bot 2014-09-19 03:30:51 UTC

Change 161418 had a related patch set uploaded by Brian Wolff:
Add missing </div> tag to packed-overlay galleries

https://gerrit.wikimedia.org/r/161418

Comment 4 Gerrit Notification Bot 2014-09-19 05:00:21 UTC

Change 161418 merged by jenkins-bot:
Add missing </div> tag to packed-overlay galleries

https://gerrit.wikimedia.org/r/161418

Comment 5 Jon 2014-09-19 05:08:29 UTC

thanks Brian! embarrassing indeed! :)

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links