Last modified: 2014-09-24 08:45:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73036, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 71036 - Default timezone always UTC when using HHVM despite settings in config
Default timezone always UTC when using HHVM despite settings in config
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: hhvm
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-09-19 09:25 UTC by James Alexander
Modified: 2014-09-24 08:45 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description James Alexander 2014-09-19 09:25:22 UTC
Currently we have just under 200 wikis using 'non standard' default time zones (set in http://noc.wikimedia.org/conf/InitialiseSettings.php.txt ) where the default time zone is something other then UTC. That default time zone is used (unless it's changed in the preferences) for all interface timestamp displays (such as recent changes, user contributions or page histories). It is also used (whether you change your preferences or not) for the time stamp in an onwiki signature. 

When you enable the HHVM beta feature on one of these wikis the time zone is defaulted to UTC regardless of the setting in InitialiseSettings. This then shows the UTC times in the interface displays. It does NOT appear to change the time zone used for signatures.

Duplication steps to see:

1. Go to a wiki with a non standard default time zone (example: sv.wikipedia.org or http://noc.wikimedia.org/conf/InitialiseSettings.php.txt)

2. Go to the beta features page (example: https://sv.wikipedia.org/wiki/Special:Preferences#mw-prefsection-betafeatures ) and make sure you do not have HHVM enabled. 

3. Go to you appearance preferences (example: https://sv.wikipedia.org/wiki/Special:Preferences#mw-prefsection-rendering ) and ensure you are on the 'use wiki default' time zone. If you are not switch to it. [you can see here that the default shows in parens the time zone used such as 'Europe/Berlin'] 

4. Go to (or open in a new tab) a page showing interface time stamps such as contributions (example: https://sv.wikipedia.org/wiki/Special:Contributions/Jalexander-WMF ) [you can see the time stamps in the local wiki default]

5. Go back to beta features page, check HHVM and save.

6. Go back to (or refresh) the page showing interface time stamps. [you will see them changed, now displayed in UTC]

7. You can also view the appearance preferences page again. [you will see the 'use wiki default' now shows +00:00 as the time zone]

8. You can go back to the beta features page, uncheck HHVM and save. [all previous pages will revert back to the original wiki default.]

It does NOT appear that signature time stamps change (they are still in the wiki default as defined in the wiki config settings)
Comment 1 Gerrit Notification Bot 2014-09-19 10:12:47 UTC
Change 161439 had a related patch set uploaded by Ori.livneh:
Don't manipulate the environment to determine TZ offset

https://gerrit.wikimedia.org/r/161439
Comment 2 Gerrit Notification Bot 2014-09-19 16:48:06 UTC
Change 161439 merged by jenkins-bot:
Don't manipulate the environment to determine TZ offset

https://gerrit.wikimedia.org/r/161439
Comment 3 Ori Livneh 2014-09-19 18:02:11 UTC
James: thanks a ton for the excellent bug report. I pushed out a fix just now and I think the problem is gone. Can you confirm?
Comment 4 James Alexander 2014-09-19 18:55:34 UTC
(In reply to Ori Livneh from comment #3)
> James: thanks a ton for the excellent bug report. I pushed out a fix just
> now and I think the problem is gone. Can you confirm?

Aye, I have not been able to replicate it anymore after checking out a couple wikis so looks like it's set! Thank you for the speedy fix!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links