Last modified: 2014-11-07 22:54:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73040, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 71040 - 923 ORA-00923: FROM keyword not found where expected
923 ORA-00923: FROM keyword not found where expected
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Installer (Other open bugs)
1.24rc
All All
: High blocker (vote)
: ---
Assigned To: Bawolff (Brian Wolff)
:
Depends on:
Blocks: oracle
  Show dependency tree / graph
 
Reported: 2014-09-19 15:08 UTC by Bill Traynor
Modified: 2014-11-07 22:54 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Bill Traynor 2014-09-19 15:08:04 UTC 
Installing a fresh MediaWiki (git master) to Oracle 11:

923 ORA-00923: FROM keyword not found where expected

Query: 

INSERT INTO UPDATELOG SELECT 'filearchive-fa_major_mime-patch-fa_major_mime-chemical.sql' AS ul_key, null as ul_value UNION SELECT 'image-img_major_mime-patch-img_major_mime-chemical.sql', null UNION SELECT 'oldimage-oi_major_mime-patch-oi_major_mime-chemical.sql', null UNION SELECT 'user_groups-ug_group-patch-ug_group-length-increase-255.sql', null UNION SELECT 'user_former_groups-ufg_group-patch-ufg_group-length-increase-255.sql', null UNION SELECT 'user_properties-up_property-patch-up_property.sql', null 

Function: DatabaseOracle::doQuery

Error: 923 ORA-00923: FROM keyword not found where expected

Backtrace:

#0 /u1/MediaWiki/includes/db/DatabaseOracle.php(422): DatabaseOracle->reportQueryError('ORA-00923: FROM...', 923, 'INSERT INTO UPD...', 'DatabaseOracle:...')
#1 /u1/MediaWiki/includes/db/DatabaseOracle.php(1240): DatabaseOracle->doQuery('INSERT INTO UPD...')
#2 /u1/MediaWiki/includes/db/Database.php(3860): DatabaseOracle->sourceStream(Resource id #129, false, false, 'DatabaseBase::s...', false)
#3 /u1/MediaWiki/includes/installer/DatabaseInstaller.php(196): DatabaseBase->sourceFile('/u1/MediaWiki/m...')
#4 /u1/MediaWiki/includes/installer/DatabaseInstaller.php(227): DatabaseInstaller->stepApplySourceFile('getUpdateKeysPa...', 'updates', false)
#5 [internal function]: DatabaseInstaller->insertUpdateKeys(Object(OracleInstaller))
#6 /u1/MediaWiki/includes/installer/Installer.php(1584): call_user_func(Array, Object(OracleInstaller))
#7 /u1/MediaWiki/includes/installer/WebInstallerPage.php(1418): Installer->performInstallation(Array, Array)
#8 /u1/MediaWiki/includes/installer/WebInstaller.php(280): WebInstallerInstall->execute()
#9 /u1/MediaWiki/mw-config/index.php(79): WebInstaller->execute(Array)
#10 /u1/MediaWiki/mw-config/index.php(38): wfInstallerMain()
#11 {main}
Comment 1 Bawolff (Brian Wolff) 2014-09-19 17:55:21 UTC 
For reference, issue introduced in https://gerrit.wikimedia.org/r/#/c/135756/
Comment 2 Gerrit Notification Bot 2014-09-19 18:16:49 UTC 
Change 161491 had a related patch set uploaded by Brian Wolff:
[UNTESTED] Add Oracle version of update-keys.sql

https://gerrit.wikimedia.org/r/161491
Comment 3 Bill Traynor 2014-09-19 18:35:50 UTC 
Testing resulted in new error:

A database query error has occurred. This may indicate a bug in the software.

Query: 
INSERT IGNORE INTO UPDATELOG (ul_key, ul_value) VALUES( 'filearchive-fa_major_mime-patch-fa_major_mime-chemical.sql', null ) 
Function: DatabaseOracle::doQuery
Error: 925 ORA-00925: missing INTO keyword
Backtrace:

#0 /u1/MediaWiki/includes/db/DatabaseOracle.php(422): DatabaseOracle->reportQueryError('ORA-00925: miss...', 925, 'INSERT IGNORE I...', 'DatabaseOracle:...')
#1 /u1/MediaWiki/includes/db/DatabaseOracle.php(1240): DatabaseOracle->doQuery('INSERT IGNORE I...')
#2 /u1/MediaWiki/includes/db/Database.php(3890): DatabaseOracle->sourceStream(Resource id #128, false, false, 'DatabaseBase::s...', false)
#3 /u1/MediaWiki/includes/installer/DatabaseInstaller.php(196): DatabaseBase->sourceFile('/u1/MediaWiki/m...')
#4 /u1/MediaWiki/includes/installer/DatabaseInstaller.php(227): DatabaseInstaller->stepApplySourceFile('getUpdateKeysPa...', 'updates', false)
#5 [internal function]: DatabaseInstaller->insertUpdateKeys(Object(OracleInstaller))
#6 /u1/MediaWiki/includes/installer/Installer.php(1584): call_user_func(Array, Object(OracleInstaller))
#7 /u1/MediaWiki/includes/installer/WebInstallerPage.php(1418): Installer->performInstallation(Array, Array)
#8 /u1/MediaWiki/includes/installer/WebInstaller.php(280): WebInstallerInstall->execute()
#9 /u1/MediaWiki/mw-config/index.php(79): WebInstaller->execute(Array)
#10 /u1/MediaWiki/mw-config/index.php(38): wfInstallerMain()
#11 {main}
Comment 4 Bill Traynor 2014-09-19 19:01:51 UTC 
Second patch applied and test and the installation process completed.
Comment 5 Gerrit Notification Bot 2014-10-24 22:23:40 UTC 
Change 161491 merged by jenkins-bot:
Add Oracle version of update-keys.sql

https://gerrit.wikimedia.org/r/161491
Comment 6 Gerrit Notification Bot 2014-11-06 16:33:33 UTC 
Change 171558 had a related patch set uploaded by MarkAHershberger:
Add Oracle version of update-keys.sql

https://gerrit.wikimedia.org/r/171558
Comment 7 Gerrit Notification Bot 2014-11-06 16:40:07 UTC 
Change 171558 merged by jenkins-bot:
Add Oracle version of update-keys.sql

https://gerrit.wikimedia.org/r/171558
Comment 8 Marcin Cieślak 2014-11-07 21:40:43 UTC 
Doesn't UNION SELECT work for Oracle? I think just adding "SELECT .... FROM DUAL" should work there?
Comment 9 Tim Landscheidt 2014-11-07 22:54:57 UTC 
(Reading comment #4, I assume the patch fixed the issue.)
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links