Last modified: 2014-09-22 17:09:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73057, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 71057 - CirrusSearch: insource highlighting
CirrusSearch: insource highlighting
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CirrusSearch (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-09-19 18:24 UTC by Nik Everett
Modified: 2014-09-22 17:09 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Nik Everett 2014-09-19 18:24:32 UTC 
We should highlight results of insource queries.  If there is a regex in the query then we should only highlight regex matches.  If there isn't a regex we should highlight whatever portion of the source matches.
Comment 1 Gerrit Notification Bot 2014-09-19 22:04:35 UTC 
Change 161611 had a related patch set uploaded by Manybubbles:
Highlighting for insource

https://gerrit.wikimedia.org/r/161611
Comment 2 Gerrit Notification Bot 2014-09-22 16:52:31 UTC 
Change 161611 merged by jenkins-bot:
Highlighting for insource

https://gerrit.wikimedia.org/r/161611
Comment 3 Nik Everett 2014-09-22 17:09:55 UTC 
The code for this is merged but not yet deployed.  The regex highlighting suffers from problems with multi byte characters (Bug 71126).  The code to fix that has also been merged but it requires an Elasticsearch rolling restart which is a pain so it'll wait longer to be deployed.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links