Last modified: 2014-09-19 21:01:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73070, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 71070 - QA: qunit test should have caught ext.flow.new error
QA: qunit test should have caught ext.flow.new error
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Shahyar Ghobadpour
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-09-19 21:01 UTC by spage
Modified: 2014-09-19 21:01 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description spage 2014-09-19 21:01:46 UTC 
Check out 0e560b8 (enwiki 1.24wmf21 as of 2014-09-12) and load a Topic, it exhibits Bug 71054 error in browser console.  ResourceLoader knows something went wrong, `mw.loader.getState( 'ext.flow.new' )` prints "error".

We should figure out why qunit tests didn't catch this and fix or add a test.  qunit has a built-in test for failed RL modules <https://git.wikimedia.org/blob/mediawiki%2Fcore.git/3daf61814db326f81c612186754f545c0548501e/tests%2Fqunit%2Fdata%2Ftestrunner.js#L442>.

If I load by hand with mw.loader.getState('ext.module.new') there's no error, I guess there's some specific interaction on Topic: that a qunit test needs to mimic.  (I'm also confused why https://test2.wikipedia.org/wiki/Special:JavaScriptTest/qunit doesn't run extension qunit tests.)

I'll file a separate bug to add 
  step "page has no ResourceLoader errors"
to Topic loading in tests/browser
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links