Last modified: 2014-10-29 08:47:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73100, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 71100 - wbformatvalue called twice when creating statement
wbformatvalue called twice when creating statement
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=frontend p=0
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-09-21 10:03 UTC by Bene*
Modified: 2014-10-29 08:47 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot of Firebug console (221.96 KB, image/jpeg)
2014-09-21 10:04 UTC, Bene*
Details

Description Bene* 2014-09-21 10:03:44 UTC
When creating a statement through the Wikidata ui the wbformatvalue api gets called twice with exactly the same parameters.

Browser: Firefox 32.0.2
Inspected with: Firebug 2.0.4
Comment 1 Bene* 2014-09-21 10:04:44 UTC
Created attachment 16533 [details]
Screenshot of Firebug console
Comment 2 Henning 2014-10-29 08:47:19 UTC
Investigated on that: The problem occurs only when adding a new statement via the "global" "add" button--in contrast to adding a statement to an existing statement/claim group.

Behaviour:
The statementview gets recreated twice after saving, with one of them getting dumped immediately. The statementview widgets are controlled by what is called claimlistview at the moment. After a new statementview has been saved, the claimlistview is supposed to re-add the re-initialized statementview to its list. Consequently, the statementview is re-added to the claimlistview that acts as container within the "pending statement" section. However, the "pending statement" section is completely dumped immediately since the parent claimgrouplistview creates a new claimgroup for the statement--or adds the statement to an existing claimgroup respectively.

Solution:
In the specific case, the claimgrouplistview would need to abort the "afterstopediting" procedure imposed by the claimlistview.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links