Last modified: 2014-09-22 10:02:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73105, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 71105 - Vector - variables.less content size too big
Vector - variables.less content size too big
Status: RESOLVED INVALID
Product: MediaWiki skins
Classification: Unclassified
Vector (Other open bugs)
1.23
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-09-22 03:05 UTC by David C. Rankin
Modified: 2014-09-22 10:02 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description David C. Rankin 2014-09-22 03:05:08 UTC
After updating an older mediawiki install to 1.23.3, the font-size of the site was too big. It completely changed the character of the site. This was surprising as update of a second install to 1.23.3 had no font-size problems. 

After grepping through the /skins/vector files the problem was found. The update to 1.23.3 the site that retained the proper font-size contained vector files dated Jan 27 2014, while the site where the font rendered too big had the same files dated Aug 27 2014. This made no sense because both sites were update by:

cd /srv/http/htdocs
mv mediawiki mediawiki-old
tar -xzf ~/tmp/mediawiki-1.23.3.tar.gz
ln -s mediawiki-1.23.3 mediawiki
cp -a mediawiki-old/LocalSettings.php mediawiki
cp -a mediawiki-old/skins/common/images/510* mediawiki/skins/common/images
read/verify RELEASE-NOTES-1.23
<done>

No skin files related to the vector skin were copied from old -> new. However, the Vector.php and skins/vector/* files ended up with two completely different file dates (as shown above). The specific file controlling vector font-size and causing the problem was variables.less.

The old/correct Jan 27 vector/variables.less file contained the following:

 @content-font-size: 0.8em;
 @content-line-height: 1.5em;
 @content-padding: 1.5em 1.5em 1.5em 1.75em;
 @content-heading-font-size: 1.6em;

The Aug 27 vector/variables.less file contained:

 @content-font-size: 0.875em;
 @content-line-height: 1.6;
 @content-padding: 1em;
 @content-heading-font-size: 1.8em;

I don't know how the updates ended up with two different versions of the vector skin, but it sure screwed up the look of the site. However this occurred, it shouldn't have and this should be clearly noted in the RELEASE-NOTES and the change corrected.
Comment 1 Andre Klapper 2014-09-22 10:02:34 UTC
The canonical download is at https://releases.wikimedia.org/mediawiki/1.23/mediawiki-1.23.3.tar.gz and includes files dated August 27th.

The changes that you refer to were introduced in Feb/Mar 2014: https://git.wikimedia.org/blame/mediawiki%2Fcore.git/fc4a89da97699c6e0d6e5fd3a908c41bf9da9cc6/skins%2Fvector%2Fvariables.less as part of https://www.mediawiki.org/wiki/Typography_refresh .

https://www.mediawiki.org/wiki/Release_notes/1.23 lists "Changes to content typography (colors, line-height, etc.)."

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links