Last modified: 2014-10-28 18:40:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73112, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 71112 - SpecialCite's i18n is still being loaded which is breaking CiteThisPage in BetaLabs
SpecialCite's i18n is still being loaded which is breaking CiteThisPage in Be...
Status: RESOLVED FIXED
Product: Wikimedia Labs
Classification: Unclassified
deployment-prep (beta) (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: James Forrester
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-09-22 05:36 UTC by James Forrester
Modified: 2014-10-28 18:40 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description James Forrester 2014-09-22 05:36:48 UTC
Ideally we'd need a way to not load it from production's extension-list…
Comment 1 Krinkle 2014-09-22 05:47:24 UTC
http://en.wikipedia.beta.wmflabs.org/wiki/Special:Cite
> Page not found

Should redirect to CiteThisPage (as configured by CiteThisPage.alias.php).

http://en.wikipedia.beta.wmflabs.org/wiki/Special:CiteThisPage
> Works

http://de.wikipedia.beta.wmflabs.org/wiki/Special:Cite
> Redirects to Spezial:Zitierhilfe
> Page not found

Should display page.

http://de.wikipedia.beta.wmflabs.org/wiki/Special:CiteThisPage
> Redirects to Spezial:Zitierhilfe
> Page not found

Should display page.


I can instantiate SpecialCiteThisPage from mwscript eval.php for both enwiki and dewiki on deployment-beta.

The mediawiki-config is set correctly (it loads SpecialCiteThisPage when $wmgUseCiteThisPage is true, and otherwise it loads SpecalCite). Beta loads CiteThisPage, prod loads Cite.

The only thing I could find that might cause this problem is the fact that extension-list contains the old SpecialCite, and thus localisation update -> $wgExtensionEntryPointListFiles -> mergeMessageFileList.php -> wgExtensionMessagesFiles contains conflicting information.

There is a way to add extensions for -labs only, but there doesn't seem to be way to add an extension for prod only without it also loading in labs and at this point the two extensions are mutually exclusive. We should:

1) Not deploy to beta (remove) and switch both later at the same time.

2) or; Fix the old and new extensions to somehow to co-exist.

3) or; Implement a way to add extensions in prod only, and give up that beta is always production + modifications.
Comment 2 James Forrester 2014-09-22 16:46:39 UTC
(In reply to Krinkle from comment #1)
> We should:
> 
> 1) Not deploy to beta (remove) and switch both later at the same time.

After talking it through with Greg, we're probably going to deploy it all at once at some point in mid-October. We'll work out and communicate this to the wikis so they have a heads-up.
Comment 3 Gerrit Notification Bot 2014-10-24 19:50:30 UTC
Change 158121 had a related patch set uploaded by Greg Grossmeier:
Switch from SpecialCite to CiteThisPage on all wikis

https://gerrit.wikimedia.org/r/158121
Comment 4 Greg Grossmeier 2014-10-24 19:52:01 UTC
Planned for Tuesday Oct 28th (this coming Tuesday)
Comment 5 Gerrit Notification Bot 2014-10-28 18:18:09 UTC
Change 158121 merged by jenkins-bot:
Switch from SpecialCite to CiteThisPage on all wikis

https://gerrit.wikimedia.org/r/158121
Comment 6 James Forrester 2014-10-28 18:40:29 UTC
Now fixed in Beta Labs.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links