Last modified: 2014-09-25 05:46:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73122, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 71122 - File history table header incomplete
File history table header incomplete
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.24rc
All All
: Lowest trivial (vote)
: ---
Assigned To: Robert Morley
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-09-22 16:09 UTC by Robert Morley
Modified: 2014-09-25 05:46 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Robert Morley 2014-09-22 16:09:25 UTC
The columns on the left of the file history table on a file page are not marked as headers, making the formatting look wrong. While this could have been intentional, it really looks ugly and should probably be updated.

Solution: in ImagePage.php->beginImageHistoryList(), change the two instances of <td></td> to <th></th>.
Comment 1 Andre Klapper 2014-09-22 18:43:35 UTC
Hi Robert! Thanks for your report and investigation!

If you feel like cooking up a patch, you are welcome to use Developer access
  https://www.mediawiki.org/wiki/Developer_access
to submit a patch as a Git branch directly into Gerrit:
  https://www.mediawiki.org/wiki/Git/Tutorial

Putting your branch in Git makes it easier to review it quickly. If you don't want to set up Git/Gerrit, you can also use https://tools.wmflabs.org/gerrit-patch-uploader/
Thanks again!
Comment 2 Robert Morley 2014-09-22 18:48:19 UTC
Thanks for the info, Andre. I was thinking this would be a stupidly simple way to get involved in the project, but wasn't sure where to start. Especially being Linux newb, the whole process can be a bit overwhelming. I'll have a look at your links and see where it gets me. :)
Comment 3 Robert Morley 2014-09-24 22:25:03 UTC
This is my very first attempt to submit an update, and I was basically following the Gerrit tutorial blindly, so please let me know if I did anything wrong.

The commit is here: https://gerrit.wikimedia.org/r/#q,I622ddac6ea5bd1a3f8c14253e70c1a5a4c56b478,n,z
Comment 4 Matthew Flaschen 2014-09-24 22:27:59 UTC
Thanks, Robert.  Normally, we mark commits as FIXED when they are merged, not when they are uploaded.  I'll review it later today if someone else doesn't beat me to it.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links