Last modified: 2014-11-15 12:18:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73123, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 71123 - can't use incategory: or intitle: when category or title contains double quotes
can't use incategory: or intitle: when category or title contains double quotes
Status: PATCH_TO_REVIEW
Product: MediaWiki
Classification: Unclassified
Search (Other open bugs)
unspecified
All All
: Low normal (vote)
: ---
Assigned To: Nik Everett
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-09-22 16:30 UTC by kipod
Modified: 2014-11-15 12:18 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description kipod 2014-09-22 16:30:58 UTC
in hebrew, double quotes is often used to denote acronyms. e.g., [[he:Category:כדורגלני בית"ר ירושלים]]. 
afaicr, the "old" search allowed for this by interpreting double-double-quotes ("") as "escaped" double quotes, so you would search for
incategory:"כדורגלני בית""ר ירושלים"

cirrus search does not allow this. 

i may be mistaken WRT old search (is there a way to test old search on hewiki?), but i know it *is* broken with cirrus. 

peace.
Comment 1 Nik Everett 2014-09-22 16:57:01 UTC
You can test the old search by adding &srbackend=LuceneSearch to the url.  It seems to blow up with an http error at the moment though.  Sad:(

Anyway, you are right that there is no way to search with that quote in there in Cirrus.  I'll fix it now but it'll take until next Thursday (really late GMT) for it to be deployed.

In other places in Cirrus you can escape it by placing a " before it so that is what I will implement.  Let me know if that works for you.
Comment 2 Gerrit Notification Bot 2014-09-22 17:16:40 UTC
Change 161986 had a related patch set uploaded by Manybubbles:
Support escaped quotes in filters

https://gerrit.wikimedia.org/r/161986
Comment 3 kipod 2014-09-22 19:30:04 UTC
sorry for not being clear - we need the same logic for intitle:
(quotes can be part of an article name, just as they appear in cat names)


as far as i could understand the patch, it should solve this also, but the description (aka "commit message") talks specifically about incategory, so i wanted to make sure...


i think the same "escape mechanism" already works for the search string itself, no?

peace.
Comment 4 Nik Everett 2014-09-22 19:38:27 UTC
It should work with all the filters like intitle, incategory, and linksto.  I've updated the commit message to be more clear.
Comment 5 Gerrit Notification Bot 2014-09-22 22:53:24 UTC
Change 161986 merged by jenkins-bot:
Support escaped quotes in filters

https://gerrit.wikimedia.org/r/161986
Comment 6 Andre Klapper 2014-11-15 12:18:34 UTC
All patches mentioned in this report were merged or abandoned - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links