Last modified: 2014-11-17 17:06:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73134, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 71134 - VisualEditor: [Regression wmf1] Increasing indentation to a bullet/numbered list is also adding a slug with a new bullet/numbered point each time
VisualEditor: [Regression wmf1] Increasing indentation to a bullet/numbered l...
Status: RESOLVED WONTFIX
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-09-22 20:13 UTC by Rummana Yasmeen
Modified: 2014-11-17 17:06 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot (14.24 KB, image/png)
2014-09-22 20:13 UTC, Rummana Yasmeen
Details
Screenshot in wmf22 (82.23 KB, image/png)
2014-09-25 18:59 UTC, Rummana Yasmeen
Details

Description Rummana Yasmeen 2014-09-22 20:13:00 UTC
Created attachment 16537 [details]
Screenshot

Steps to reproduce:


1.Open a page with VE
2.Insert a bullet list or numbered list
3.Now try to add indentation to one of the item

Observed Result:
Apart from adding indentation, it ia also adding a new line and a new bullet point/numbered point


Environment:Betalabs
Comment 1 James Forrester 2014-09-22 20:25:28 UTC
Due to the changes in how slugs work, presumably?
Comment 2 Ed Sanders 2014-09-25 15:56:51 UTC
Can you give more detailed instructions. I'm seeing slugs in lists but only in sensible places.
Comment 3 Rummana Yasmeen 2014-09-25 18:59:55 UTC
Created attachment 16592 [details]
Screenshot in wmf22

Okay, so if I compare the behavior of indentation in wmf 22 , it didnt add any slug when I increase indentation for any bullet list.It just added indentation for that bullet point moving it to the right.But now it is adding a slug ,See the screenshot attached for wmf 22 to compare how it used to work.
Comment 4 Ed Sanders 2014-09-25 20:48:15 UTC
I think it makes sense to have a slug there, as a double indented list is actually a list wrapped in a list, so you need to be able to split them and insert content.

Also you shouldn't double indent a list without content between, so this make it clear something is being done wrongly.
Comment 5 James Forrester 2014-09-25 22:59:27 UTC
(In reply to Ed Sanders from comment #4)
> I think it makes sense to have a slug there, as a double indented list is
> actually a list wrapped in a list, so you need to be able to split them and
> insert content.
> 
> Also you shouldn't double indent a list without content between, so this
> make it clear something is being done wrongly.

Sure, except you were the one to change the behaviour to this a few months ago, to match read mode rendering…
Comment 6 Mark A. Hershberger 2014-11-12 17:59:42 UTC
This is probably part related to Bug #37938, Bug #48010, and Bug #58335.
Comment 7 James Forrester 2014-11-13 11:33:05 UTC
(In reply to Mark A. Hershberger from comment #6)
> This is probably part related to Bug #37938, Bug #48010, and Bug #58335.

No, this has nothing to do with those bugs; it's about the visual display of empty structural list items.
Comment 8 Ed Sanders 2014-11-17 15:18:33 UTC
Recommend wontfix. There's no regular case to start a list at double indentation. This change doesn't event prevent that, just makes it visually clear what structure you should use.
Comment 9 James Forrester 2014-11-17 17:06:18 UTC
(In reply to Ed Sanders from comment #8)
> Recommend wontfix. There's no regular case to start a list at double
> indentation. This change doesn't event prevent that, just makes it visually
> clear what structure you should use.

Very well.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links