Last modified: 2014-10-30 00:01:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73157, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 71157 - VisualEditor: [Regression wmf1] Template parameter autovalues are not saved


Summary:	VisualEditor: [Regression wmf1] Template parameter autovalues are not saved

Status:	RESOLVED FIXED

Product:	VisualEditor
Classification:	Unclassified
Component:	Editing Tools (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal normal
Target Milestone:	VE-deploy-2014-10-23 (1.25wmf5)
Assigned To:	Roan Kattouw

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-09-23 00:36 UTC by Rummana Yasmeen
Modified:	2014-10-30 00:01 UTC (History)
CC List:	8 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Screenshot (36.92 KB, image/png) 2014-09-23 00:36 UTC, Rummana Yasmeen	Details
Add an attachment (proposed patch, testcase, etc.)

Description Rummana Yasmeen 2014-09-23 00:36:37 UTC

Created attachment 16545 [details]
Screenshot

Steps to reproduce:


1.Open a page with VE
2.Insert the template "Citation needed"
3.Observe that in the field for "Month and year", the following has been used:
{{subst:CURRENTMONTHNAME}} {{subst:CURRENTYEAR}}
4.Now click on "Apply Changes"
5.Save the page
6.Reopen the page
7.Open the transclusion dialog for the "Citation Needed" template

Observed Result:
The current month name and current year value did not get added in the field.


Environment:Betalabs

Comment 1 Roan Kattouw 2014-10-22 21:55:43 UTC

Definitely VE's fault. We're somehow not sending the parameter value to Parsoid when saving.

Comment 2 Gerrit Notification Bot 2014-10-22 22:48:15 UTC

Change 168204 had a related patch set uploaded by Catrope:
Actually set parameter autoValues as values

https://gerrit.wikimedia.org/r/168204

Comment 3 Gerrit Notification Bot 2014-10-22 22:48:21 UTC

Change 168205 had a related patch set uploaded by Catrope:
Apply pre-save transform to template previews

https://gerrit.wikimedia.org/r/168205

Comment 4 Gerrit Notification Bot 2014-10-22 22:53:53 UTC

Change 168204 merged by jenkins-bot:
Actually set parameter autoValues as values

https://gerrit.wikimedia.org/r/168204

Comment 5 Gerrit Notification Bot 2014-10-27 18:38:44 UTC

Change 168205 merged by jenkins-bot:
Apply pre-save transform to template previews

https://gerrit.wikimedia.org/r/168205

Comment 6 etonkovidova 2014-10-27 19:11:58 UTC

Verified in betalabs.

Comment 7 Rummana Yasmeen 2014-10-29 23:04:11 UTC

This seem to be not working in production (en.wiki).I dont even see the substitute values {{subst:CURRENTMONTHNAME}} {{subst:CURRENTYEAR}} for the parameters.

Comment 8 Roan Kattouw 2014-10-30 00:00:19 UTC

(In reply to Rummana Yasmeen from comment #7)
> This seem to be not working in production (en.wiki).I dont even see the
> substitute values {{subst:CURRENTMONTHNAME}} {{subst:CURRENTYEAR}} for the
> parameters.

This seems to be because the Citation needed template on enwiki doesn't have the autovalue set up yet. James said he would do this, but he was waiting for this bug to be fixed.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links