Last modified: 2014-10-08 11:39:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73171, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 71171 - namespaceDupes.php doesn't update references in other tables for pages it moved
namespaceDupes.php doesn't update references in other tables for pages it moved
Status: NEW
Product: MediaWiki
Classification: Unclassified
Maintenance scripts (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-09-23 11:59 UTC by Matthias Mullie
Modified: 2014-10-08 11:39 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Matthias Mullie 2014-09-23 11:59:22 UTC
namespaceDupes.php is used when introducing a new namespace, to check/move titles that already use the new (namespace) prefix to be introduced.

The actual rename happens in NamespaceConflictChecker::resolveConflictOn() in namespaceDupes.php. All it does is update the pages in the `page` table.

However, there are plenty of other places that reference such namespace/title pairs that are not properly updated.

Is there any reason NamespaceConflictChecker::resolveConflictOn() doesn't use Title::moveTo? That one does seem to update references in a lot of the other tables as well, and runs hooks (TitleMove & TitleMoveComplete) that extensions can subscribe to in order to update their data.
Can we change it to use Title::moveTo?

--

A non-exhaustive list of tables with namespace/title references that may contain incorrect references after such rename:

* abuse_filter_log
* archive
* cu_changes
* echo_event
* edit_page_tracking
* flaggedrevs_tracking
* flaggedtemplates
* flow_ext_ref
* flow_wiki_ref
* flow_workflow
* globalimagelinks
* hidden
* imagelinks?
* job
* lgging
* pagelinks
* protected_titles
* querycache
* querycachetwo
* recentchanges
* redirect
* templatelinks
* thread
* translate_stash
* watchlist

--

When Flow recently introduced Topic:, we encountered a problem with unmoved references in `watchlist` table: https://bugzilla.wikimedia.org/show_bug.cgi?id=71109

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links