Last modified: 2014-10-13 20:55:25 UTC
Created attachment 16554 [details] screenshot showing "Use this Group" menu items appearing as cut-off Environment-test2, beta 1> In VE, select Cite -> Basic. 2>In the Reference dialog, click on the "Use this Group" pull-down menu .Notice the menu items appear cut-off and are not visible properly.Please see the screenshot at this step.
See MWLinkTargetInputWidget does this – the menu needs to use a different overlay. Roan claims this is relatively easy. :-)
(In reply to James Forrester from comment #1) > See MWLinkTargetInputWidget does this – the menu needs to use a different > overlay. Roan claims this is relatively easy. :-) That code actually has more indirection than I thought. All you need to do is pass the $overlay config option to the widget (anything that mixes in LookupInputWidget will work) and set it to the surface's localOverlay. This is what the link inspector does too, but indirectly. DesktopContext#createInspectorWindowManager sets an overlay on the window manager, and LinkInspector then grabs the manager's overlay and passes it into the LinkTargetInputWidget subclass as $overlay.
Change 163299 had a related patch set uploaded by Alex Monk: Don't cut off "Use this group" dropdown menu in reference dialogs https://gerrit.wikimedia.org/r/163299
Change 163300 had a related patch set uploaded by Alex Monk: ComboBoxWidget: Append menu to $overlay option https://gerrit.wikimedia.org/r/163300
Change 163301 had a related patch set uploaded by Alex Monk: DesktopSurface#createDialogWindowManage: Send overlay object to WindowManager https://gerrit.wikimedia.org/r/163301
*** Bug 71374 has been marked as a duplicate of this bug. ***
*** Bug 71470 has been marked as a duplicate of this bug. ***
Change 164361 had a related patch set uploaded by Alex Monk: Move window overlay up to be a sibling of the frame https://gerrit.wikimedia.org/r/164361
Change 163301 abandoned by Alex Monk: DesktopSurface#createDialogWindowManage: Send overlay object to WindowManager Reason: Abandoning in favour of I7e0294bb instead https://gerrit.wikimedia.org/r/163301
Change 163299 abandoned by Alex Monk: Don't cut off "Use this group" dropdown menu in reference dialogs Reason: Done in I7e0294bb, abandoning this one https://gerrit.wikimedia.org/r/163299
Change 164361 merged by jenkins-bot: Move window overlay up to be a sibling of the frame https://gerrit.wikimedia.org/r/164361
Change 163300 merged by jenkins-bot: ComboBoxWidget: Append menu to $overlay option https://gerrit.wikimedia.org/r/163300
Should be fixed.
I can still reproduce it on both beta and test2.
What about now? beta won't show OOjs UI fixes until it actually has the latest copy of OOjs UI.
(In reply to Alex Monk from comment #15) > What about now? beta won't show OOjs UI fixes until it actually has the > latest copy of OOjs UI. I checked with a clear cache in test2 and still the list item is displayed truncated.
It's working for me on deployment-prep. test2 won't be updated until Thursday.
hi Alex, when i click on the combo box arrow it just puts the cursor in it.Earlier doing the same action, used to show the "General References" in a drop-down list with a check beside it.
(In reply to Ritu Swain from comment #18) > hi Alex, when i click on the combo box arrow it just puts the cursor in > it.Earlier doing the same action, used to show the "General References" in a > drop-down list with a check beside it. Both in beta and test2.
I don't see how that's related to this bug.
The original issue was to fix the menu item(i,e. General References) which was appearing cut-off and was not visible properly. The issue is not fixed because now when i click on the combo box arrow it does not show the drop-down.Instead just places the cursor inside the combo box.However, when you start typing, the list showing General References as a item does appear. If this sounds confusing, please follow the steps below-: 1> select Cite -> Basic. 2>In the Reference dialog, click on the arrow in "Use this Group" combo box.Notice doing so above step just brings the box into focus. 3>Now while the cursor is still in the box type in. When the first character is entered you see the drop-down list with "General References" as an option. Expected- The drop-down list with General References, should show up when i click on the combo-box arrow.
So what you mean is, this issue is fixed but the fix caused a different issue, which is the indicator button not working properly.
The fix for this bug changed ComboBoxWidget from using MenuWidget to using TextInputMenuWidget. However, TextInputMenuWidget#toggle seems to have not been handling undefined values properly. I've uploaded Gerrit change #166512 to fix this.
