Last modified: 2014-09-24 18:15:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73220, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 71220 - Flow: JavaScript errors and wrong result from post moderation actions performed in new window
Flow: JavaScript errors and wrong result from post moderation actions perform...
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
master
All All
: Unprioritized minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-09-24 06:14 UTC by spage
Modified: 2014-09-24 18:15 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2014-09-24 06:14:29 UTC
While logged in and viewing a Flow board, bring up a post's action menu and right-click on a moderation action such as "Hide post" to open it in a new window.  E.g. http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Topic:S2kt8ok5dha81gzk&action=moderate-post&topic_postId=s2kt8ok6xlpvdnpc&topic_moderationState=hide

In addition to the poor "disconnected" UX for this standalone action...
When you enter a reason and click Hide,

1. You get a JS error
  TypeError: data.flow[action] is undefined
  http://bits.beta.wmflabs.org/static-master/extensions/Flow/modules/new/components/flow-board.js
  Line 1100

2. If you reload the topic, the entire topic is hidden, not just the moderated post.


Similarly, bring up a *topic*'s action menu and right-click on the "Hide topic" action to open it in a new window.

E.g. http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Topic:S2kt8ok5dha81gzk&action=moderate-topic&topic_moderationState=hide

when you enter a reason and click Hide, you get a different JS error
  TypeError: $target is undefined
  http://bits.beta.wmflabs.org/static-master/extensions/Mantle/javascripts/externals/handlebars.js line 2082 > Function/event/seq/1/anonymous
  Line 1120

Normally only users not running JavaScript will see this UX, since if you click the action item it takes place in the current page. So I think it's low-priority.
Comment 1 Danny Horn 2014-09-24 18:15:12 UTC
Added to backlog: https://trello.com/c/zmDQS2g0

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links