Last modified: 2014-10-02 20:55:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73237, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 71237 - VisualEditor: [Regression pre-wmf1] Link button does nothing
VisualEditor: [Regression pre-wmf1] Link button does nothing
Status: VERIFIED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Highest major
: VE-deploy-2014-09-25
Assigned To: Roan Kattouw
: browser-test-bug
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-09-24 16:07 UTC by Chris McMahon
Modified: 2014-10-02 20:55 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Chris McMahon 2014-09-24 16:07:56 UTC 
Edit any page on beta labs e.g. http://en.wikipedia.beta.wmflabs.org/wiki/Media_Interface_VisualEditor_Test?veaction=edit

Click the Link button. Nothing happens.

Error console shows "TypeError: this.isValid(...).done is not a function"

No other controls seem to be affected by this issue.
Comment 1 Gerrit Notification Bot 2014-09-24 18:50:14 UTC 
Change 162646 had a related patch set uploaded by Catrope:
Account for isValid() becoming async

https://gerrit.wikimedia.org/r/162646
Comment 2 Gerrit Notification Bot 2014-09-24 18:51:15 UTC 
Change 162647 had a related patch set uploaded by Catrope:
Make MWLinkTargetInputWidget#isValid asynchronous

https://gerrit.wikimedia.org/r/162647
Comment 3 Gerrit Notification Bot 2014-09-24 19:08:49 UTC 
Change 162646 merged by jenkins-bot:
Account for isValid() becoming async

https://gerrit.wikimedia.org/r/162646
Comment 4 Gerrit Notification Bot 2014-09-24 19:24:44 UTC 
Change 162647 merged by jenkins-bot:
Update VE core submodule to master (6e68242)

https://gerrit.wikimedia.org/r/162647
Comment 5 Rummana Yasmeen 2014-09-24 20:37:41 UTC 
Verified the fix in Betalabs
Comment 6 Rummana Yasmeen 2014-09-25 22:39:28 UTC 
verified the fix in test2
Comment 7 Rummana Yasmeen 2014-10-02 20:55:48 UTC 
Verified the fix in production
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links