Last modified: 2014-10-09 17:33:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73286, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 71286 - Download link should save to a sensible filename with extension etc.
Download link should save to a sensible filename with extension etc.
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Collection (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: C. Scott Ananian
https://en.wikipedia.org/w/index.php?...
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-09-25 08:32 UTC by Nemo
Modified: 2014-10-09 17:33 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Nemo 2014-09-25 08:32:18 UTC 
A download URL like this is offered by the interface, which (at least in Firefox 32) saves to a a file like
$ file 3de5e15c0acbde1deccff87bb7a3a90197b42135
3de5e15c0acbde1deccff87bb7a3a90197b42135: PDF document, version 1.5

Wonderful, but better would be "3de5e15c0acbde1deccff87bb7a3a90197b42135.pdf" or "Diffuser.pdf" (do we have a function in core to produce Windows-proof filenames?). This is for OCG/rdf2latex but probably any other rendering as well.
Comment 1 Nemo 2014-09-26 06:28:18 UTC 
#749 "Better default names for files" was probably related.
Comment 2 C. Scott Ananian 2014-10-03 22:50:17 UTC 
Partially fixed by https://gerrit.wikimedia.org/r/164613 (which adds the missing extension).  We could do better about using the article title for the filename, though, and my reading of the RFC for contents disposition indicates that we might have an issue here with filename characters outside iso8859-1 as well.
Comment 3 Gerrit Notification Bot 2014-10-07 15:00:09 UTC 
Change 165213 had a related patch set uploaded by Cscott:
Use article title as download filename.

https://gerrit.wikimedia.org/r/165213
Comment 4 Gerrit Notification Bot 2014-10-07 17:26:02 UTC 
Change 165213 merged by jenkins-bot:
Use article title as download filename.

https://gerrit.wikimedia.org/r/165213
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links