Last modified: 2014-10-07 11:08:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73310, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 71310 - OOjs UI: TextInputWidget's textarea gets silly scrollbars when it shouldn't
OOjs UI: TextInputWidget's textarea gets silly scrollbars when it shouldn't
Status: RESOLVED FIXED
Product: OOjs UI
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Normal minor
: ---
Assigned To: Bartosz Dziewoński
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-09-25 16:19 UTC by Ritu Swain
Modified: 2014-10-07 11:08 UTC (History)
3 users (show)

See Also:
Web browser: Google Chrome
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
screenshot showing scrollbars in insert comment box (77.61 KB, image/png)
2014-09-25 16:19 UTC, Ritu Swain
Details

Description Ritu Swain 2014-09-25 16:19:09 UTC
Created attachment 16585 [details]
screenshot showing scrollbars in insert comment box

Environment- test2, beta, production

1> In VE, click to insert a comment.
2> In the comment box, type in some text. Hit enter.
3> Repeat step#2, just to add multiple lines of text.
4> Notice the text area scrollbar and one more scrollbar gets added to the box(happens after entering the 3rd line).It would be nice to have just one scrollbar. There is already one for the Edit comment box.
Comment 1 Bartosz Dziewoński 2014-09-29 16:16:05 UTC
This is two issues:

* The comment inspector isn't autosized correctly (after closing it and
  viewing the newly created comment, the inspector will be larger).
* The textarea inside has a silly vertical scrollbar that scrolls only by
  one pixel up or down when a scrollbar shouldn't be necessary.
Comment 2 Bartosz Dziewoński 2014-09-29 18:03:10 UTC
(In reply to Bartosz Dziewoński from comment #1)
> * The textarea inside has a silly vertical scrollbar that scrolls only by
>   one pixel up or down when a scrollbar shouldn't be necessary.

This only happens in Blink browsers (and in IE when the textarea is two lines high, but that's a different bug and it's on our side this time).
Comment 3 Gerrit Notification Bot 2014-09-29 18:07:52 UTC
Change 163632 had a related patch set uploaded by Bartosz Dziewoński:
TextInputWidget: Don't mix inner and outer heights in calculations

https://gerrit.wikimedia.org/r/163632
Comment 4 Gerrit Notification Bot 2014-09-29 19:54:43 UTC
Change 163659 had a related patch set uploaded by Bartosz Dziewoński:
TextInputWidget: Work around Blink height miscalculation

https://gerrit.wikimedia.org/r/163659
Comment 5 Bartosz Dziewoński 2014-09-29 20:15:24 UTC
(In reply to Bartosz Dziewoński from comment #1)
> * The comment inspector isn't autosized correctly (after closing it and
>   viewing the newly created comment, the inspector will be larger).

Split off to bug 71427. The two patches above fix the other half of this bug.
Comment 6 Gerrit Notification Bot 2014-09-30 22:20:18 UTC
Change 163632 merged by jenkins-bot:
TextInputWidget: Don't mix inner and outer heights in calculations

https://gerrit.wikimedia.org/r/163632
Comment 7 Gerrit Notification Bot 2014-09-30 22:21:34 UTC
Change 163659 merged by jenkins-bot:
TextInputWidget: Work around Blink height miscalculation

https://gerrit.wikimedia.org/r/163659
Comment 8 Ritu Swain 2014-10-06 15:32:22 UTC
(In reply to Bartosz Dziewoński from comment #1)
> 
> * The textarea inside has a silly vertical scrollbar that scrolls only by
>   one pixel up or down when a scrollbar shouldn't be necessary.

The double scrollbar reappears after entering the 10th line of text , in the insert comment box.
Comment 9 Bartosz Dziewoński 2014-10-07 11:08:22 UTC
I think that's the part tracked as bug 71427.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links