Last modified: 2014-09-26 08:40:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73345, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 71345 - WikimediaEvents breaks Special:Preferences on Beta
WikimediaEvents breaks Special:Preferences on Beta
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikimediaEvents (Other open bugs)
master
All All
: Unprioritized critical (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-09-26 07:56 UTC by Kartik Mistry
Modified: 2014-09-26 08:40 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Kartik Mistry 2014-09-26 07:56:45 UTC
Error at, http://es.wikipedia.beta.wmflabs.org/wiki/Especial:Preferencias

Unexpected non-MediaWiki exception encountered, of type "BadMethodCallException"
[766c5fc8] /wiki/Especial:Preferencias Exception from line 345 of /srv/mediawiki/php-master/extensions/WikimediaEvents/WikimediaEventsHooks.php: Call to a member function get() on a non-object (NULL)
Backtrace:
#0 /srv/mediawiki/php-master/includes/Hooks.php(206): WikimediaEventsHooks::onGetBetaFeaturePreferences(User, array)
#1 /srv/mediawiki/php-master/includes/GlobalFunctions.php(3991): Hooks::run(string, array, NULL)
#2 /srv/mediawiki/php-master/extensions/BetaFeatures/BetaFeaturesHooks.php(157): wfRunHooks(string, array)
#3 /srv/mediawiki/php-master/includes/Hooks.php(206): BetaFeaturesHooks::getPreferences(User, array)
#4 /srv/mediawiki/php-master/includes/GlobalFunctions.php(3991): Hooks::run(string, array, NULL)
#5 /srv/mediawiki/php-master/includes/Preferences.php(99): wfRunHooks(string, array)
#6 /srv/mediawiki/php-master/includes/Preferences.php(1236): Preferences::getPreferences(User, RequestContext)
#7 /srv/mediawiki/php-master/includes/specials/SpecialPreferences.php(58): Preferences::getFormObject(User, RequestContext)
#8 /srv/mediawiki/php-master/includes/specialpage/SpecialPage.php(363): SpecialPreferences->execute(NULL)
#9 /srv/mediawiki/php-master/includes/specialpage/SpecialPageFactory.php(584): SpecialPage->run(NULL)
#10 /srv/mediawiki/php-master/includes/MediaWiki.php(275): SpecialPageFactory::executePath(Title, RequestContext)
#11 /srv/mediawiki/php-master/includes/MediaWiki.php(584): MediaWiki->performRequest()
#12 /srv/mediawiki/php-master/includes/MediaWiki.php(435): MediaWiki->main()
#13 /srv/mediawiki/php-master/index.php(46): MediaWiki->run()
#14 /srv/mediawiki/w/index.php(3): include(string)
#15 {main}

Thanks.
Comment 1 Antoine "hashar" Musso (WMF) 2014-09-26 08:16:25 UTC
   public static function onGetBetaFeaturePreferences( User $user, array &$prefs ) {
        $iconpath = $coreConfig->get( 'ExtensionAssetsPath' ) . "/WikimediaEvents";
  ...

Obviously $coreConfig is undefined.

Code was added by: https://gerrit.wikimedia.org/r/#/c/162008/

It even got cherry picked to wmf branch and deployed, but I am not able to reproduce the issue on the production wikis :-/
Comment 2 Gerrit Notification Bot 2014-09-26 08:20:03 UTC
Change 163123 had a related patch set uploaded by Hashar:
Revert "HHVM BetaFeature: Add screenshot; improve text"

https://gerrit.wikimedia.org/r/163123
Comment 3 Ori Livneh 2014-09-26 08:29:15 UTC
Fixed in https://gerrit.wikimedia.org/r/#/c/163126/
Comment 4 Gerrit Notification Bot 2014-09-26 08:36:43 UTC
Change 163123 abandoned by Hashar:
Revert "HHVM BetaFeature: Add screenshot; improve text"

Reason:
Bah got fixed by Ori in wmf branches, will cherry pick the wmf branch patch to master.

https://gerrit.wikimedia.org/r/163123
Comment 5 Antoine "hashar" Musso (WMF) 2014-09-26 08:40:55 UTC
Ori fixed it in wmf branches and simply forgot to pick the patch on master. He did so with https://gerrit.wikimedia.org/r/#/c/163126/

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links