Last modified: 2014-11-13 14:38:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73353, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 71353 - Echo pings are not recognized if the signature uses custom namespace alias (defined per-wiki, rather than for the language)
Echo pings are not recognized if the signature uses custom namespace alias (d...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Echo (Other open bugs)
master
All All
: High normal (vote)
: ---
Assigned To: Erik Bernhardson
:
: 70236 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-09-26 12:08 UTC by Bartosz Dziewoński
Modified: 2014-11-13 14:38 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bartosz Dziewoński 2014-09-26 12:08:33 UTC
Apparently Echo pings are not recognized if the signature uses custom namespace alias (defined per-wiki, rather than for the language).

Support for localised namespaces was implemented per bug 53132, but custom aliases don't work.
Comment 1 Gerrit Notification Bot 2014-09-26 12:59:27 UTC
Change 163152 had a related patch set uploaded by Bartosz Dziewoński:
DiscussionParser: Support custom namespace aliases in signatures

https://gerrit.wikimedia.org/r/163152
Comment 2 Gerrit Notification Bot 2014-09-26 16:07:18 UTC
Change 163152 abandoned by Bartosz Dziewoński:
DiscussionParser: Support custom namespace aliases in signatures

Reason:
Okay.

https://gerrit.wikimedia.org/r/163152
Comment 3 Quiddity 2014-09-26 18:00:34 UTC
Patch abandoned, resetting to New.   :(
Comment 4 Sunpriat 2014-09-26 18:46:52 UTC
also did not work when using an alias not in the signature

correctly: [[user:A]] text ~~~~ ->[[user:X]] text [[urer:B]]
my variant: [[u:A]] text ~~~~ -> [[u:X]] text [[urer:B]]
Comment 5 Quiddity 2014-09-26 19:02:29 UTC
*** Bug 70236 has been marked as a duplicate of this bug. ***
Comment 6 Bartosz Dziewoński 2014-09-26 22:34:34 UTC
The patch can be restored if anyone appeases code reviewers, it works perfectly. But I am not going to rewrite half of Echo to make everyone happy.
Comment 7 Gerrit Notification Bot 2014-09-27 02:28:56 UTC
Change 163327 had a related patch set uploaded by EBernhardson:
Make signatures within parser output findable

https://gerrit.wikimedia.org/r/163327
Comment 8 Gerrit Notification Bot 2014-09-29 19:43:52 UTC
Change 163651 had a related patch set uploaded by EBernhardson:
Detect signature using Title class

https://gerrit.wikimedia.org/r/163651
Comment 9 Gerrit Notification Bot 2014-09-29 19:57:04 UTC
Change 163327 abandoned by EBernhardson:
Make signatures within parser output findable

Reason:
move forward with the earlier patch that does same thing

https://gerrit.wikimedia.org/r/163327
Comment 10 Sunpriat 2014-10-04 13:32:34 UTC
(In reply to Sunpriat from comment #4)
> also did not work when using an alias not in the signature
> 
> correctly: [[user:A]] text ~~~~ ->[[user:X]] text [[urer:B]] 
> <s>my variant: [[u:A]] text ~~~~ -> [[u:X]] text [[urer:B]]</s>
[[У:A]] text ~~~~ -> [[У:X]] text [[У:B]]
but not, then was also an alias in the signature. Alias in ruWP by default in the signature...
Comment 11 Gerrit Notification Bot 2014-10-23 21:25:39 UTC
Change 163651 merged by jenkins-bot:
Detect signature using Title class

https://gerrit.wikimedia.org/r/163651
Comment 12 Bartosz Dziewoński 2014-10-23 21:26:34 UTC
The fix has been merged and should be deployed within two weeks.
Comment 13 Helder 2014-11-13 14:38:35 UTC
And we are back... =/

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links