Last modified: 2014-10-03 20:18:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73373, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 71373 - VisualEditor: [Regression wmf1] Link inspector does not close when clicking out into non-linked text
VisualEditor: [Regression wmf1] Link inspector does not close when clicking o...
Status: VERIFIED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High major
: VE-deploy-2014-10-02
Assigned To: Roan Kattouw
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-09-26 22:25 UTC by Roan Kattouw
Modified: 2014-10-03 20:18 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Roan Kattouw 2014-09-26 22:25:53 UTC 
1. Open VisualEditor
2. Find or create a paragraph with a link followed by some non-linked text
3. Inspect the link
4. While the link inspector is open, click to drop the cursor in the non-linked text

The link inspector does not close, and instead moves to follow your selection.
Comment 1 Roan Kattouw 2014-09-26 22:49:57 UTC 
This broke in https://gerrit.wikimedia.org/r/#/c/162495/ , which made it so contextChange is no longer emitted when the selection moves from inside a link to outside a link.
Comment 2 Bartosz Dziewoński 2014-09-27 00:50:53 UTC 
Related? Bug 71151.
Comment 3 Roan Kattouw 2014-09-27 00:53:42 UTC 
(In reply to Bartosz Dziewoński from comment #2)
> Related? Bug 71151.

Yes, absolutely. While investigating this, I wished I had "git bisect concerning" in addition to "good" and "bad". At first, nothing was wrong, then the flicker started happening, and now it doesn't close at all.

I think this happened because Ed changed the context to reposition itself directly from events emitted by the surface. The surface also emits a contextChange event that causes the context to realize that it should close (or did; this bug is about that event not being emitted any more), but that event listener is debounced, so we close the context after moving it.
Comment 4 Gerrit Notification Bot 2014-09-30 00:36:13 UTC 
Change 163783 had a related patch set uploaded by Catrope:
Followup b149390: fix dm.Surface's concept of "selectedNode" to match SurfaceFragment's

https://gerrit.wikimedia.org/r/163783
Comment 5 Gerrit Notification Bot 2014-09-30 13:48:05 UTC 
Change 163783 merged by jenkins-bot:
Followup b149390: fix dm.Surface's concept of "selectedNode" to match SurfaceFragment's

https://gerrit.wikimedia.org/r/163783
Comment 6 Gerrit Notification Bot 2014-09-30 14:15:25 UTC 
Change 163852 had a related patch set uploaded by Jforrester:
Followup b149390: fix dm.Surface's concept of "selectedNode" to match SurfaceFragment's

https://gerrit.wikimedia.org/r/163852
Comment 7 Gerrit Notification Bot 2014-09-30 14:17:37 UTC 
Change 163852 merged by jenkins-bot:
Followup b149390: fix dm.Surface's concept of "selectedNode" to match SurfaceFragment's

https://gerrit.wikimedia.org/r/163852
Comment 8 James Forrester 2014-09-30 15:21:13 UTC 
Merged into master and deployed to wmf1.
Comment 9 Rummana Yasmeen 2014-10-03 20:18:44 UTC 
Verified the fix in test2 and production
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links