Last modified: 2014-10-26 10:58:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73401, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 71401 - have an option to pass upload warning for imagetransfer.py


Summary:	have an option to pass upload warning for imagetransfer.py

Status:	RESOLVED FIXED

Product:	Pywikibot
Classification:	Unclassified
Component:	Other scripts (Other open bugs)
Version:	core-(2.0)
Hardware:	All All

Importance:	Unprioritized normal
Target Milestone:	---
Assigned To:	reza1615

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-09-29 06:56 UTC by reza1615
Modified:	2014-10-26 10:58 UTC (History)
CC List:	2 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description reza1615 2014-09-29 06:56:35 UTC

I want to use imagetransfer.py inside other bot and using it automaticlay
when an image is deleted before on local wiki (target wiki) it asks:

Do you want to ignore? ([y]es, [N]o)

It is much better to have an option for ignoring API warning (the image was deleted warning).

Comment 1 reza1615 2014-09-29 08:53:15 UTC

at line 198

bot = upload.UploadRobot(url=url, description=description,
                                     targetSite=self.targetSite,
                                     urlEncoding=sourceSite.encoding(),
                                     keepFilename=self.keep_name,
                                     verifyDescription=not self.keep_name)

Should be

bot = upload.UploadRobot(url=url, description=description,
                                     targetSite=self.targetSite,
                                     urlEncoding=sourceSite.encoding(),
                                     keepFilename=self.keep_name,
                                     verifyDescription=not self.keep_name,
                                     ignoreWarning=False)

Comment 2 Gerrit Notification Bot 2014-10-04 09:13:18 UTC

Change 164722 had a related patch set uploaded by Reza:
Making upload API warning ignorable

https://gerrit.wikimedia.org/r/164722

Comment 3 Gerrit Notification Bot 2014-10-04 18:52:25 UTC

Change 164722 merged by jenkins-bot:
Making upload API warning ignorable

https://gerrit.wikimedia.org/r/164722

Comment 4 Jesús Martínez Novo (Ciencia Al Poder) 2014-10-26 10:58:38 UTC

Patch merged

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links