Last modified: 2014-09-30 18:11:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73417, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 71417 - VisualEditor: [Regression wmf1] Add a Template dialog does not open, when adding a new Basic reference
VisualEditor: [Regression wmf1] Add a Template dialog does not open, when add...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High major
: VE-deploy-2014-10-02
Assigned To: Roan Kattouw
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-09-29 16:09 UTC by Ritu Swain
Modified: 2014-09-30 18:11 UTC (History)
6 users (show)

See Also:
Web browser: Google Chrome
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ritu Swain 2014-09-29 16:09:30 UTC
Environment- test2

1> In VE, open Basic citation dialog and enter any citation(book,news,Web or Journal). For ex- enter a book citation.
2> Now while the citation is still highlighted select Insert  -> Template.Notice the Add a Template window does not open , instead it opens the Cite Book dialog.

But if you enter a book citation in the CE and while it is still highlighted try to open the Template dialog(Insert  -> Template) . Notice the Add a Template dialog opens.
Comment 1 Ritu Swain 2014-09-29 16:14:33 UTC
http://youtu.be/sy91ReXk_f4
Comment 2 James Forrester 2014-09-30 01:25:34 UTC
I believe this has now been fixed and backported as part of the fix for bug 71418.
Comment 3 Ritu Swain 2014-09-30 15:00:37 UTC
(In reply to James Forrester from comment #2)
> I believe this has now been fixed and backported as part of the fix for bug
> 71418.

I can still reproduce it, in both test2 and beta.
Comment 4 James Forrester 2014-09-30 16:37:29 UTC
I can't; have you refreshed?

The citation template now opens as expected.
Comment 5 Ritu Swain 2014-09-30 16:53:37 UTC
(In reply to James Forrester from comment #4)
>
> 
> 

I checked with a clear history.It still does not open the "Add a Template" dialog ,when a  book citation is highlighted in Basic reference dialog.

Instead it opens the Cite Book dialog.
Comment 6 James Forrester 2014-09-30 16:56:08 UTC
(In reply to Ritu Swain from comment #5)
> I checked with a clear history.It still does not open the "Add a Template"
> dialog ,when a  book citation is highlighted in Basic reference dialog.
> 
> Instead it opens the Cite Book dialog.

Oh, right, you weren't talking about the other bug in this report. Yes, opening any of the dialogs when you've selected that item (selecting a template and clicking the template button; an image and the media button; a reference and the reference button) will always open the item for editing rather than insert a new one, by design. Sorry for the confusion.
Comment 7 Ritu Swain 2014-09-30 17:12:10 UTC
(In reply to James Forrester from comment #6)
> (In reply to Ritu Swain from comment #5)
> > I checked with a clear history.It still does not open the "Add a Template"
> > dialog ,when a  book citation is highlighted in Basic reference dialog.
> > 
> > Instead it opens the Cite Book dialog.
> 
> Oh, right, you weren't talking about the other bug in this report. Yes,
> opening any of the dialogs when you've selected that item (selecting a
> template and clicking the template button; an image and the media button; a
> reference and the reference button) will always open the item for editing
> rather than insert a new one, by design. Sorry for the confusion.

Thank you, i got it now. 

But when i try the above steps in the Content Editor or the Editor in the Media Settings Caption.

For ex- 
1> click on cite -> book and insert a book citation.
2> Now while the citation is still highlighted select Insert  -> Template.Notice the Add a Template modal opens , and not the Cite Book dialog.

If this is how it is supposed to behave in different editors, then please ignore this issue.
Comment 8 James Forrester 2014-09-30 17:43:31 UTC
(In reply to Ritu Swain from comment #7)
> (In reply to James Forrester from comment #6)
> > (In reply to Ritu Swain from comment #5)
> > > I checked with a clear history.It still does not open the "Add a Template"
> > > dialog ,when a  book citation is highlighted in Basic reference dialog.
> > > 
> > > Instead it opens the Cite Book dialog.
> > 
> > Oh, right, you weren't talking about the other bug in this report. Yes,
> > opening any of the dialogs when you've selected that item (selecting a
> > template and clicking the template button; an image and the media button; a
> > reference and the reference button) will always open the item for editing
> > rather than insert a new one, by design. Sorry for the confusion.
> 
> Thank you, i got it now. 
> 
> But when i try the above steps in the Content Editor or the Editor in the
> Media Settings Caption.
> 
> For ex- 
> 1> click on cite -> book and insert a book citation.
> 2> Now while the citation is still highlighted select Insert  ->
> Template.Notice the Add a Template modal opens , and not the Cite Book
> dialog.
> 
> If this is how it is supposed to behave in different editors, then please
> ignore this issue.

It is. When you insert "Cite > Book" in the editor, it inserts a citation – a reference with a template inside it. When you try this inside a reference, it cleverly inserts the template, not a reference inside a reference (which isn't allowed). It's a little confusing, clearly. :-(
Comment 9 Ritu Swain 2014-09-30 18:11:52 UTC
Thank you once again :), will keep that in mind.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links