Last modified: 2014-11-06 01:38:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73454, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 71454 - Some test runs are verbose
Some test runs are verbose
Status: PATCH_TO_REVIEW
Product: Pywikibot
Classification: Unclassified
tests (Other open bugs)
core-(2.0)
All All
: Unprioritized normal
: ---
Assigned To: Pywikipedia bugs
: upstream
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-09-30 00:34 UTC by John Mark Vandenberg
Modified: 2014-11-06 01:38 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description John Mark Vandenberg 2014-09-30 00:34:13 UTC
Some test runs become verbose, without a user config setting for verbosity.  This previously occurred for travis builds against ar.wikipedia.

https://travis-ci.org/wikimedia/pywikibot-core/jobs/34230160

Current travis builds do not exhibit this behaviour, however it still occurs on my ar.wikipedia test runs.
Comment 1 John Mark Vandenberg 2014-10-09 05:39:01 UTC
The cause of the problem appears to be flickrapi 1.4.4 which calls logging.basicConfig(), which is not appropriate for a library.

https://bitbucket.org/sybren/flickrapi/src/e91ab5c64c7ed036a7397474ec31f9b16d3e62a9/flickrapi/__init__.py?at=branch-1.4#cl-68

The bug stopped happening on travis because script_tests first checks for ImageTk, which fails for travis builds, so flickrapi isnt loaded

https://travis-ci.org/wikimedia/pywikibot-core/jobs/37419168

"flickrripper depends on ImageTk, which isnt available:
No module named ImageTk"
Comment 2 John Mark Vandenberg 2014-10-09 05:42:13 UTC
Bug raised:
https://bitbucket.org/sybren/flickrapi/issue/51/loggingbasicconfig
Comment 3 John Mark Vandenberg 2014-11-06 00:00:45 UTC
Now that we've fixed all the other issues with flickrripper, this is now causing builds to fail.

Some options:
1. use a custom build of flickrapi 1.4.4 for tests
2. use the hg master build of flickrapi for tests
3. somehow detect what flickrapi 1.4.4 has done and undo it

The simplest fix is option 2
Comment 4 Gerrit Notification Bot 2014-11-06 00:14:50 UTC
Change 171479 had a related patch set uploaded by John Vandenberg:
Use flickrapi master for tests

https://gerrit.wikimedia.org/r/171479
Comment 5 Gerrit Notification Bot 2014-11-06 01:38:12 UTC
Change 171491 had a related patch set uploaded by John Vandenberg:
Use custom flickrapi 1.4

https://gerrit.wikimedia.org/r/171491

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links