Last modified: 2014-11-10 12:09:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73482, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 71482 - Erwin's tools: Broken layout due to shared.css 404 Not Found
Erwin's tools: Broken layout due to shared.css 404 Not Found
Status: RESOLVED FIXED
Product: Tool Labs tools
Classification: Unclassified
Erwin's tools (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-09-30 21:33 UTC by Andre Koopal
Modified: 2014-11-10 12:09 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Andre Koopal 2014-09-30 21:33:27 UTC
Via Common.css the following css is included:

@import "//bits.wikimedia.org/static-current/skins/common/shared.css";

After advice on irc, tried to pull a copy to use locally from:

https://github.com/wikimedia/mediawiki-core/blob/master/resources/src/mediawiki.legacy/shared.css

But that still gives wrong layout, so probably not the correct version. Will need more searching to find the right one again.
Comment 2 Krinkle 2014-10-01 23:34:38 UTC
Loading raw css files hasn't been the standard practice since 2010.

Instead of requesting the raw file directly - which is unsupported (MediaWiki can change this at any time with no announcement, this is not a documented interface) - Use ResourceLoader instead, for example:

https://bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=mediawiki.legacy.shared&only=styles

This avoids requesting raw files and forces you to make the same decisions the wiki software does (pick a specific wiki, language and module name).

Advantages:
* More caching.
* Smaller file size (minification).
* Officially supported and documented (we'll let you know if it is planned to change, plus migration period).

Regardless of whether the wiki upgrades to a newer version and whether the files are moved around internally (or split up into several files), it will continue to work as expected.
Comment 3 Derk-Jan Hartman 2014-11-08 15:13:34 UTC
Replaced with load.php calls and updated the HTML to be compatible

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links