Last modified: 2014-10-19 17:44:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73531, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 71531 - Move user agent assignment to Ruby gem
Move user agent assignment to Ruby gem
Status: NEW
Product: Wikimedia
Classification: Unclassified
Quality Assurance (Other open bugs)
wmf-deployment
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-10-01 20:32 UTC by Chris McMahon
Modified: 2014-10-19 17:44 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Chris McMahon 2014-10-01 20:32:55 UTC
Three repos (Echo, Flow, MobileFrontend) are using this step: 

Given(/^I am using user agent "(.+)"$/) do |user_agent|
  @user_agent = user_agent
  @browser = browser(test_name(@scenario), {user_agent: user_agent})
  $session_id = @browser.driver.instance_variable_get(:@bridge).session_id
end

and doing that properly requires the @custom_browser tag. 

We should move this code into the Ruby gem so it is not repeated among 3 repos. 

Also, more repos will probably be testing no-javascript mode in the future, so this would likely see even more re-use. 

Finally, the shared code should throw an error if BROWSER is anything other than Firefox

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links